Loop through list of ip-addresses [SOLVED]

[AlphaInc]

Hello everybody,

I want to use a python script to check if certain ips are still online and if not, i want the system to shut down.
Therefore I have created a list of client ip's and a loop to check every ip if its online or not and then, if all ip's are down, execute a command (in this example it is the command #Command1) and if not, it should execute another command (in this exampe #Command2).

def ip_check():
    hosts = [
    "192.168.180.100",
    "192.168.180.101",
    "192.168.180.102",
    "192.168.180.103",
    "192.168.180.104",
    "192.168.180.105",
    "192.168.180.106"
    ]
   
    for x in hosts:
        host_response = os.system("ping -c 1 " + str(hosts))

    if guest_response == 0:
        #Command1
    else:
        #Command2

The problem is, all i get is this output and I don't know how to fix it:

ping: 192.168.180.106]: Name or service not known
ping: 192.168.180.106]: Name or service not known
ping: 192.168.180.106]: Name or service not known
ping: 192.168.180.106]: Name or service not known
ping: 192.168.180.106]: Name or service not known
ping: 192.168.180.106]: Name or service not known
ping: 192.168.180.106]: Name or service not known

[menator01]

You need to move the if/else statement into the for loop to check each ip

[AlphaInc]

You need to move the if/else statement into the for loop to check each ip

Like this?:

        for x in hosts:
        host_response = os.system("ping -c 1 " + str(hosts))
        if host_response == 0:
            print ("Command1")
        else:
            print ("Command2")

I still get this message:

ping: 192.168.180.106]: Name or service not known
Command2
ping: 192.168.180.106]: Name or service not known
Command2
ping: 192.168.180.106]: Name or service not known
Command2
ping: 192.168.180.106]: Name or service not known
Command2
ping: 192.168.180.106]: Name or service not known
Command2
ping: 192.168.180.106]: Name or service not known
Command2
ping: 192.168.180.106]: Name or service not known
Command2

[menator01]

if/else inside the for loop

import os
def ip_check():

    hosts = [f'192.168.180.{index}' for index in range(100, 107)]
    for x in hosts:
        host_response = os.system(f"ping -n 1 {x}")

        if host_response == 0:
            print('command 1')
        else:
            print('command 2')

ip_check()

[AlphaInc]

if/else inside the for loop

def ip_check():
    hosts = [
    "192.168.180.100",
    "192.168.180.101",
    "192.168.180.102",
    "192.168.180.103",
    "192.168.180.104",
    "192.168.180.105",
    "192.168.180.106"
    ]
    
    for x in hosts:
        host_response = os.system("ping -c 1 " + str(hosts))

        if host_response == 0:
            print('command 1')
        else:
            print('command 2')
    

I copied your code 1:1 but I still get the message that the name or service (106) is not known...

[menator01]

I updated the code above. coarse I changed -c to -n

[AlphaInc]

I updated the code above. coarse I changed -c to -n

Okay nice, that works.
And what if the ips don't come in a row (for example .10, .55 and .104) ?

[menator01]

I updated the code above. coarse I changed -c to -n

Okay nice, that works.
And what if the ips don't come in a row (for example .10, .55 and .104) ?

You can make your original list. The list I made was a quick way for me to do it. (If that is what you are referring to)