Function not scriptable: Noob question

[kaega2]

Hey everyone.
I keep getting the error "Function no scriptable". I don't know why.

from tkinter import Menu

MENU = {
    "espresso": {
        "ingredients": {
            "water": 50,
            "coffee": 18,
        },
        "cost": 1.5,
    },
    "latte": {
        "ingredients": {
            "water": 200,
            "milk": 150,
            "coffee": 24,
        },
        "cost": 2.5,
    },
    "cappuccino": {
        "ingredients": {
            "water": 250,
            "milk": 100,
            "coffee": 24,
        },
        "cost": 3.0,
    }
}

profit = 0

resources = {
    "water": 0,
    "milk": 0,
    "coffee": 0,
    "money": 0.00
}

def checkr(drink):
    make_drink = True
    if resources["water"] < MENU[choice]["ingredients"]["water"]:
        print("There is not enough water")
        make_drink = False
    if resources["milk"] < MENU[choice]["ingredients"]["milk"]:
        print("There is not enough milk")
        make_drink = False
    if resources["coffee"] < MENU[choice]["ingredients"]["coffee"]:
        print("There is not enough coffee grounds")
        make_drink = False
    return make_drink
        

is_on = True

while is_on:
    choice = input("What would you like? (espresso/latte/cappuccino): ")
    if choice == "off":
        is_on = False
    if choice == "report":
        print(f"Water: {resources['water']} ml")
        print(f"Milk: {resources['milk']} ml")
        print(f"Coffee: {resources['coffee']} ml")
        print(f"Money: ${resources['money']}")
    if choice == "latte" or choice == "espresso" or choice == "cappuccino":
        if checkr[choice] == True:
            print("Drink Made")

[Yoriz]

When posting an error please give the full error traceback in error tags

You have the wrong type of brackets on the following line, the [] brackets

if checkr[choice] == True:

should be ()

if checkr(choice) == True:

[deanhystad]

The error is "TypeError: 'function' object is not subscriptable"

It is telling you that you are trying to use "subscripts" with a function object. Square brackets are used to subscript, or index, "subscriptable" objects like lists or dictionaries. Parenthesis are used to call a function.

This is bad programming. It is too restrictive and doesn't use the information available in the MENU items.

def checkr(drink):
    make_drink = True
    if resources["water"] < MENU[choice]["ingredients"]["water"]:
        print("There is not enough water")
        make_drink = False
    if resources["milk"] < MENU[choice]["ingredients"]["milk"]:
        print("There is not enough milk")
        make_drink = False
    if resources["coffee"] < MENU[choice]["ingredients"]["coffee"]:
        print("There is not enough coffee grounds")
        make_drink = False
    return make_drink

The checkr function forces all drinks to use the same ingredients. If you add strawberry smoothies to your menu, you'll have to rewrite the checkr() function to check for strawberries, and all menu items will have to be modified to include strawberries.

I write checkr() something like this:

def checkr(drink):
    # Check if there are enough ingredients
    for ingredient, amount in MENU[drink]["ingredients"].items():
        if resources[ingredient] < amount:
            print(f"There is not enough {ingredient}")
            return False
    return True

Now checkr() only checks ingredients for the drink you are making. If you added fruit smoothies to your menu you would not have to rewrite checkr to check for strawberries, nor would you have to add them to all your menu ingredients. I would do something similar with the "report" action. The code that prints an inventory report should not have to know every possible ingredient. That information is already in the ingredients dictionary.

[kaega2]

Thank you so much!

I'm sorry for not posting logs. I knew I was just doing something really stupid and couldn't figure it out. I kept running into the error intermittently.

Thanks again!