That compression method is not supported

[tester_V]

Greetings!
I used this snippet for a while but yesterday the script crashed...
with the error:
'That compression method is not supported'
I'm expecting try/except part of the scripts to skip the 'Bad' file but it did not...
Part of the script:

from zipfile import ZipFile
from zipfile import BadZipfile
from pathlib import Path
# Some code here
try :
	with ZipFile(ef) as zz:
			for file in zz.namelist():
				zp_name = Path(file).name 
				#print(f" ZIP NAME : {zp_name}")
				if 'Trace' in file :
					zz.extract(file,temp_temp_dr_out)
except BadZipfile as er :
	print(f" Bad ZIP found -> {er}")
	continue 

Any help is appreciated.
Thank you.

[deanhystad]

Please try to use a topic that represents the question asked in the post. Your question is about try/except. You didn't ask anything about compression methods. Using a good topic gives your post value. Others having questions about the same topic will be able to find your post and maybe you can help them.

Think about how try/except works. If an exception is raised, where does the program jump too? If you think about how try/except works instead of why it didn't work here, the solution is obvious.

[tester_V]

I thought it should print the error and continue.
Am I mistaken?
Thank you.

[deanhystad]

That is exactly what it does in your program. It jumps to the exception body, which prints a message and continues. Why does that end the loop?

[tester_V]

Sorry for the confusion!
I'm expecting the program to "skip" a bad zip file if found and take the next one.
I'm not expecting the program to crash, I'm expecting it to print the "error" but it does crush.
That is strange.

THank you.

[buran]

What error do you get? Post the full traceback. Obviously it's not BadZipfile, because it's not captured. From what I see on Internet, it's NotImplementedError, so capture that error too in the except clause.

[deanhystad]

Buran might be right. What is the error message? Does it say : Bad ZIP found -> That compression method is not supported? If the message starts with "Bad ZIP found", your exception handler caught the error. If it doesn't, the exception was not caught. You've been posting to this forum for over 2 years. You know how it works. Post full error messages and the complete error trace.

Either way, your try/except will not work as you expect. If you catch the exception, the program will jump HERE (marked below) and execute the code in the exception block.

from zipfile import ZipFile
from zipfile import BadZipfile
from pathlib import Path
# Some code here
try :
    with ZipFile(ef) as zz:
            for file in zz.namelist():
                zp_name = Path(file).name 
                #print(f" ZIP NAME : {zp_name}")
                if 'Trace' in file :
                    zz.extract(file,temp_temp_dr_out)
except BadZipfile as er :
    print(f" Bad ZIP found -> {er}")   # <-- JUMP TO HERE IF BadZipFile exception
    continue 

Is the exception body inside or outside the loop?

[tester_V]

you are right, it is the case:
'That compression method is not supported? If the message starts with "Bad ZIP found", your exception handler caught the error. If it doesn't, the exception was not caught'

I added one more exception, and the script does not stop anymore.

        except BadZipfile as er :
            print(f" Bad ZIP found -> {er}")
            continue 
        except RuntimeError:
           continue 

Thank you for your help!
I really appreciate it...

[deanhystad]

You don't need to add an exception, you just need to move it inside the loop. You don't need the continue statements either.

[tester_V]

I see your point, deanhystad. I'll do that!
Thank you very much!
You guys are great!
Tester_V