Image Not Saved Properly

[jkreski]

I have the following code from a video course that produces a screenshot image on the monitor and saves a file with a valid name and extension but when you go to Explorer in Windows 11 and click on the file it says the file has a bad format. Thoughts?

import time
import pyautogui

def screenshot():
    name = int(round(time.time() * 1000))
    name = 'C:/Users/jkres/AppData/Local/Programs/Python/Python312/Programs/test/{}.png'.format(name)
    time.sleep(2)
    img = pyautogui.screenshot(name)
    img.show()
    img.save(name)

screenshot()

[deanhystad]

Works fine when for me.

You don't need this line:

img.save(name)

Calling screenshot with a name automatically saves the image to a file of that name.

What version of Python are you using? What version of pyautogui? What version of PIL (screenshot returns a PIL Image)?

[jkreski]

Thanks! I am using IDLE version 3.12.5. Python is 3.12. pyautogui was just installed yesterday so I think it should be the most current version. The only PIL I can find is: PIL-1.1.7-py2.7. I didn't think I needed the SAVE but thought maybe if I forced it then it would save it properly.

[snippsat]

Thanks! I am using IDLE version 3.12.5.

Do not run IDLE when using automation or any GUI related stuff.
Because IDLE can block operation.
From command line python your_code.py.

[jkreski]

Thanks! I am using IDLE version 3.12.5.

Do not run IDLE when using automation or any GUI related stuff.
Because IDLE can block operation.
From command line python your_code.py.

I opened a command prompt and changed directory to my code directory and ran the command. Same result. Bad file type. Also, when I tried to run the code from Visual Studio Code I got the error message pyautogui could not be resolved from source. It did run and I got the same result.

[snippsat]

The only PIL I can find is: PIL-1.1.7-py2.7.

This is an old version,unisntall and reinstall.
It's called pillow now for long time.

pip uninstall Pillow
pip install --upgrade pip

Check that it show Version 12.1.1.

λ pip show pillow 
Name: pillow
Version: 12.1.1
Summary: Python Imaging Library (fork)
Home-page: https://python-pillow.github.io
Author:
Author-email: "Jeffrey A. Clark" <[email protected]>
License-Expression: MIT-CMU
Location: C:\Python313\Lib\site-packages
Requires:
Required-by: weasyprint version 

[jkreski]

The only PIL I can find is: PIL-1.1.7-py2.7.

This is an old version,unisntall and reinstall.
It's called pillow now for long time.

pip uninstall Pillow
pip install --upgrade pip

Check that it show Version 12.1.1.

λ pip show pillow 
Name: pillow
Version: 12.1.1
Summary: Python Imaging Library (fork)
Home-page: https://python-pillow.github.io
Author:
Author-email: "Jeffrey A. Clark" <[email protected]>
License-Expression: MIT-CMU
Location: C:\Python313\Lib\site-packages
Requires:
Required-by: weasyprint version 

I followed the directions and have the new version but get the same results. Thanks for trying!

[Pedroski55]

You can get screenshots very simply like this:

from PIL import ImageGrab

savepath = '/home/peterr/temp/images/ss1.jpg'
ss_area = (200, 200, 400, 400)
# get whole screen
# ss_img = ImageGrab.grab()

def grabit(area):
    ss_img = ImageGrab.grab(area)
    ss_img.save(savepath)

grabit(ss_area)

If you use datetime as well you can save with a timestamp!

[jkreski]

You can get screenshots very simply like this:

from PIL import ImageGrab

savepath = '/home/peterr/temp/images/ss1.jpg'
ss_area = (200, 200, 400, 400)
# get whole screen
# ss_img = ImageGrab.grab()

def grabit(area):
    ss_img = ImageGrab.grab(area)
    ss_img.save(savepath)

grabit(ss_area)

If you use datetime as well you can save with a timestamp!

Thanks but I am trying to get the code from the video course I am following to work on my machine. It works on others. I need to fix what is wrong with my software, not work around it.

[snippsat]

Try making a virtual environment(build into Python).
To make sure that not problem with Python and modules installed.
Use cmd same commands,i use cmder here.

# Make 
E:\div_code
λ python -m venv shoot_env

# Cd in
E:\div_code
λ cd shoot_env\

# Activate
E:\div_code\shoot_env
λ E:\div_code\shoot_env\Scripts\activate

# Install, when environment work will see (shoot_env)
E:\div_code\shoot_env
(shoot_env) λ pip install --no-cache-dir pyautogui pillow

I testet with your code save to folder in use,and can also use Pyautogui to save directly both work.

import time
import pyautogui

def screenshot():
    name = int(round(time.time() * 1000))
    name = f'{name}.png'.format(name)
    time.sleep(2)
    img = pyautogui.screenshot(name)
    img.show()
    img.save(name)

screenshot()

Pyautogui has own way to save,in script over it really save 2 times.

import pyautogui

img = pyautogui.screenshot()
img.save("testshot.png")