[flake8-simplify] Detect implicit else cases in needless-bool (SIM103)#10414
Merged
charliermarsh merged 20 commits intoMar 18, 2024
Merged
Conversation
ottaviohartman
commented
Mar 15, 2024
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| SIM103 | 156 | 156 | 0 | 0 | 0 |
Member
|
Thanks! Do you mind moving this to preview-only?
Yes, the best prior art here would be... let parent = checker.semantic().current_statement_parent()?;
let suite = traversal::suite(stmt, parent)?;
let sibling = traversal::next_sibling(stmt, suite)?;So, ideally, we check if the statement is an |
Contributor
Author
Yep! Is there a way to partially move (Flake8Simplify, "103") => (RuleGroup::Stable, rules::flake8_simplify::rules::NeedlessBool),
Ah, I'll refactor to use that instead! |
Member
So typically we'd just add a check for the new codepath on |
CodSpeed Performance ReportMerging #10414 will not alter performanceComparing Summary
|
Contributor
Author
|
Ready for another review @charliermarsh . Thanks for the help!
|
Contributor
Author
|
Looks like my clone() is slowing down perf tests. I'll look into that. |
| ( | ||
| if_test.as_ref(), | ||
| if_body, | ||
| std::slice::from_ref(next_stmt), |
Member
There was a problem hiding this comment.
@ottaviohartman -- I was able to remove the vector allocation here by making every branch return &[Stmt] instead of &Vec<Stmt>. Then, you can do a nice trick whereby if you have an &T, you can create &[T] via std::slice::from_ref.
Contributor
Author
There was a problem hiding this comment.
Awesome - I'll use that in the future.
charliermarsh
added
rule
charliermarsh
changed the title
SIM103 detect implicit elseflake8-simplify] Detect implicit else cases in needless-bool (SIM103)
KotlinIsland
pushed a commit
to KotlinIsland/basedpython
that referenced
this pull request
May 1, 2026
…dless-bool` (`SIM103`) (#12048) ## Summary See: astral-sh/ruff#10414. This is a good and intuitive change; we just put it in preview because it expanded scope a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10402
Summary
For SIM103, detect and simplify the following case:
playground link
Test Plan
Unit tested only.