Update D208 to preserve indentation offsets when fixing overindented lines#8699
Merged
Conversation
zanieb
force-pushed
the
zanie/fix-d208
branch
from
e2be68d to
8f58784
Compare
zanieb
force-pushed
the
zanie/fix-d208
branch
from
8f58784 to
11a2137
Compare
Contributor
|
charliermarsh
approved these changes
Nov 16, 2023
Member
Author
|
@charliermarsh any thoughts on preview? It seems like best practice? |
charliermarsh
left a comment
charliermarsh
left a comment
Member
There was a problem hiding this comment.
If I'm understanding correctly that this only affects the fix, I would be fine shipping this to stable.
Member
|
(But defer to you as the author.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8695
We track the smallest offset seen for overindented lines then only reduce the indentation of the lines that far to preserve indentation in other lines. This rule's behavior now matches our formatter, which is nice.
We may want to gate this with preview.