Skip to content

Remove @babel/core peerDep from helper-compilation-targets#15811

Merged
nicolo-ribaudo merged 1 commit into
babel:mainfrom
nicolo-ribaudo:hct-core-peer
Jul 21, 2023
Merged

Remove @babel/core peerDep from helper-compilation-targets#15811
nicolo-ribaudo merged 1 commit into
babel:mainfrom
nicolo-ribaudo:hct-core-peer

Conversation

@nicolo-ribaudo

@nicolo-ribaudo nicolo-ribaudo commented Jul 21, 2023

Copy link
Copy Markdown
Member
Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This package and all its dependencies do not use @babel/core (neither directly via imports, or indirectly like plugins do). As such, there is no need to specify @babel/core in its devDependencies and peerDependencies.

This gets rid of one of the remaining warnings mentioned in #15810, since @babel/helper-define-polyfill-provider has a dependency on this package.

@nicolo-ribaudo nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jul 21, 2023
@babel-bot

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54929/

@nicolo-ribaudo nicolo-ribaudo merged commit e8fc72f into babel:main Jul 21, 2023
@nicolo-ribaudo nicolo-ribaudo deleted the hct-core-peer branch July 21, 2023 14:00
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 21, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants