Prefer URIs with authority#3098
Merged
Merged
Conversation
There are two ways to obtain a URI of a file: * `File.toURI()` -> `file:/path/to/file.feature` * `Path.toUri()` -> `file:///path/to/file.feature` While both URIs are equal, their string representation is not. This poses some problems when comparing string based outputs. Currently, when using the Cucumber JUnit Platform Engine the latter variant is used. When using the CLI the former variant is used. The choice between the two is fairly arbitrary. But the latter seems to picked up by IDEA and turned into a clickable link. The former is not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚡️ What's your motivation?
There are two ways to obtain a URI of a file:
File.toURI()->file:/path/to/file.featurePath.toUri()->file:///path/to/file.featureWhile both URIs are equal, their string representation is not. This poses some problems when comparing string based outputs. Currently, when using the Cucumber JUnit Platform Engine the latter variant is used. When using the CLI the former variant is used. The choice between the two is fairly arbitrary. But the latter seems to picked up by IDEA and turned into a clickable link. The former is not.
🏷️ What kind of change is this?
📋 Checklist: