Rebuild lock file#3733
Merged
Merged
Conversation
Member
|
Thank you!
I wouldn't say I like this idea, as it's an additional entry point for the project. I want to keep it simple, as npm is good enough, and such problems happen rarely. We also use Bun to run timezone tests, so if anything, I would utilize it if not the previous point. I'm open to convincing, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had to rebuild the lock file to be able to run the unit tests again on macOS. Deleting the "node_modules" directory and re-installing the dependencies was not sufficient.
It appears to be a known bug, see npm/cli#4828
(While we're at it,
pnpmwould be a nice improvement for the project. It's been very fast and reliable for me over the last few years.)