fix(no-callback-in-promise): false triggering of callback#574
Merged
Conversation
scagood
reviewed
Nov 26, 2024
Co-authored-by: Sebastian Good <2230835+scagood@users.noreply.github.com>
scagood
approved these changes
Nov 26, 2024
scagood
left a comment
scagood
left a comment
Contributor
There was a problem hiding this comment.
Generally looks good to me 👍
renovate Bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Nov 27, 2024
##### [v7.2.1](https://github.com/eslint-community/eslint-plugin-promise/blob/HEAD/CHANGELOG.md#721-2024-11-26) ##### 🩹 Fixes - **`no-callback-in-promise`:** false triggering of callback ([#574](eslint-community/eslint-plugin-promise#574)) ([8324564](eslint-community/eslint-plugin-promise@8324564)) ##### 🧹 Chores - **deps-dev:** update husky to v9.1.7 ([#573](eslint-community/eslint-plugin-promise#573)) ([24fd90a](eslint-community/eslint-plugin-promise@24fd90a)) - **deps:** bump cross-spawn from 7.0.3 to 7.0.6 ([#568](eslint-community/eslint-plugin-promise#568)) ([f33f82e](eslint-community/eslint-plugin-promise@f33f82e))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Fixes regression with false triggering by callback
Fixes #572