Skip to content

chore(IWYU): Remove some redundant includes#4758

Merged
vitaut merged 1 commit into
fmtlib:mainfrom
KaganCanSit:chore/IWYU-header-cleanup
Apr 30, 2026
Merged

chore(IWYU): Remove some redundant includes#4758
vitaut merged 1 commit into
fmtlib:mainfrom
KaganCanSit:chore/IWYU-header-cleanup

Conversation

@KaganCanSit

@KaganCanSit KaganCanSit commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

Checked header dependencies using IWYU and removed includes identified as redundant. I check potential false positives and some warnings were addressed here — not all.

fmt project has platform-specific guards and backward-compatibility build paths that's why I tried to approach it as minimally as possible.

I am marking this PR draft. I want analyze CI results and check again this changes.

@KaganCanSit KaganCanSit force-pushed the chore/IWYU-header-cleanup branch from 28f4348 to f0f9900 Compare April 25, 2026 17:07
@KaganCanSit KaganCanSit force-pushed the chore/IWYU-header-cleanup branch from f0f9900 to 33b3a45 Compare April 25, 2026 17:08
@KaganCanSit

KaganCanSit commented Apr 25, 2026

Copy link
Copy Markdown
Contributor Author
#include "fmt/os.h"  // fmt::system_category
#include "fmt/ranges.h"
#include "gtest-extra.h"  // StartsWith

#ifdef __cpp_lib_filesystem
TEST(std_test, path) {
  using std::filesystem::path;
// ...
// ...
// ...
// ...
  EXPECT_EQ(fmt::format("{:?}", path(L"\xD800")), "\"\\ud800\"");
#  endif
}

// Intentionally delayed include to test #4303
#  include "fmt/ranges.h"

fmt/test/std-test.cc have two same include fmt/ranges.h. But If I change compile failed. I'll take a look at it when I have time. (I need to find the test purpose of the second include.)

@vitaut

vitaut commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

LGTM. Do you still plan to make changes to this PR or shall we merge?

@KaganCanSit

Copy link
Copy Markdown
Contributor Author

LGTM. Do you still plan to make changes to this PR or shall we merge?

Thank you for your review. We can mergw. At the moment, I haven’t been able to find the time to look into the situation I mentioned in the comment above.

@vitaut vitaut marked this pull request as ready for review April 30, 2026 03:50
@vitaut vitaut merged commit d0e3d20 into fmtlib:main Apr 30, 2026
44 checks passed
@vitaut

vitaut commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Merged, thanks!

@KaganCanSit KaganCanSit deleted the chore/IWYU-header-cleanup branch April 30, 2026 04:25
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jun 22, 2026
# 12.2.0 - 2026-06-16

- Added a C11 API that brings fast, type-safe formatting to C. The new
  `fmt-c` library and `fmt/fmt-c.h` header use `_Generic` to dispatch on
  argument types and outperform `printf`/`sprintf`. For example:

  ```c++
  #include <fmt/fmt-c.h>

  fmt_print(stdout, "The answer is {}.\n", 42);
  ```

  (fmtlib/fmt#4663,
  fmtlib/fmt#4671,
  fmtlib/fmt#4696,
  fmtlib/fmt#4693,
  fmtlib/fmt#4694,
  fmtlib/fmt#4712,
  fmtlib/fmt#4789).
  Thanks @soumik15630m, @Ferdi265 and @localspook.

- Added a separate `fmt::fmt-module` CMake target for C++20 modules and a
  CI workflow that exercises module-based builds
  (fmtlib/fmt#4684,
  fmtlib/fmt#4685,
  fmtlib/fmt#4707,
  fmtlib/fmt#4708,
  fmtlib/fmt#4702,
  fmtlib/fmt#4709).
  Thanks @MathewBensonCode.

- Enabled the full Dragonbox lookup cache by default for floating-point
  formatting unless optimizing for binary size (`__OPTIMIZE_SIZE__`),
  giving a ~10–25% speedup. Thanks Matthias Kretz for the suggestion.
  Average time per `double` on Apple M1 Pro (clang 17, random digits,
  smaller is better) measured with
  [dtoa-benchmark](https://github.com/fmtlib/dtoa-benchmark):

  | Method                  | Time (ns) |
  | ----------------------- | --------: |
  | fmt (full)              |     22.07 |
  | fmt (compact)           |     29.55 |
  | ryu                     |     35.21 |
  | double-conversion       |     81.81 |
  | `sprintf`               |    726.27 |
  | `ostringstream`         |    864.34 |

- Improved integer formatting performance by ~3%
  (fmtlib/fmt#4630). Thanks @user202729.

- Optimized formatting into back-insert iterators by using bulk container
  append/insert methods (e.g. on `std::vector<char>` and custom string
  types) (fmtlib/fmt#4679). Thanks @user202729.

- Reduced binary size of debug builds (~200k to ~85k in the bloat test) and
  improved compile speed when `consteval` is unavailable.

- Made path formatting lossless, preserving ill-formed UTF-16
  sequences when converting `std::filesystem::path` to a narrow string.

- Added support for formatting `std::unexpected`
  (fmtlib/fmt#4675). Thanks @17steen.

- Added overloads of `fmt::println` that take a `fmt::text_style`
  (fmtlib/fmt#4782). Thanks @ahoarau.

- Added support for positional arguments as width and precision specifiers
  in `fmt::printf` (fmtlib/fmt#4643).
  Thanks @KareemOtoum.

- Made `FMT_STRING` a no-op when `FMT_USE_CONSTEVAL` is enabled, since the
  consteval format-string constructor already provides compile-time
  validation
  (fmtlib/fmt#4611,
  fmtlib/fmt#4612). Thanks @friedkeenan.

- Promoted `fmt::detail::named_arg` to the public API as `fmt::named_arg` and
  deprecated the detail alias
  (fmtlib/fmt#4683,
  fmtlib/fmt#4687). Thanks @TPPPP72.

- Moved the `std::byte` formatter from `fmt/format.h` to `fmt/std.h`.

- Provided a default definition for `fmt::is_contiguous`
  (fmtlib/fmt#4731,
  fmtlib/fmt#4770). Thanks @user202729 and @phprus.

- Added the `FMT_USE_FLOCKFILE` macro to disable the use of `flockfile`
  (fmtlib/fmt#4646,
  fmtlib/fmt#4666). Thanks @mvastola.

- Added `include_guard(GLOBAL)` so that {fmt} can be used in multiple
  submodules of the same project
  (fmtlib/fmt#4672). Thanks @torsten48.

- Improved `constexpr` support
  (fmtlib/fmt#4659,
  fmtlib/fmt#4591).
  Thanks @elbeno and @17steen.

- Deprecated the implicit conversion from `fmt::format_string` and
  `fmt::basic_fstring` to `string_view` to align with `std::format_string`;
  use `format_string::get()` instead.

- Opted out `std::complex` from tuple formatting so that the dedicated
  `std::complex` formatter is always used.

- Removed the `fmt::say` function.

- Deprecated the `std::initializer_list` overload of `fmt::join` and the array
  overload of `fmt::vformat_to`.

- Made the `<fmt/core.h>` header equivalent to `<fmt/base.h>` by
  default. Code that relied on `<fmt/core.h>` pulling in `<fmt/format.h>`
  must now either include `<fmt/format.h>` directly or define
  `FMT_DEPRECATED_HEAVY_CORE` to opt back in.

- Improved `wchar_t` support: `fmt::join` now accepts `wchar_t` and other
  non-`char` separators, and `fmt::format_to_n` now works with `fmt::runtime`
  on `wchar_t`
  (fmtlib/fmt#4686,
  fmtlib/fmt#4714,
  fmtlib/fmt#4715).
  Thanks @Yancey2023 and @sunmy2019.

- Fixed formatting of `std::tm` with a null `tm_zone`
  (fmtlib/fmt#4790). Thanks @Carmel0.

- Fixed compile-time formatting in `fmt/ranges.h`, `fmt/style.h` and
  `fmt/std.h` (fmtlib/fmt#4759). Thanks @j4niwzis.

- Fixed an ambiguity between `formatter<std::optional<T>>` in `fmt/std.h`
  and `fmt/ranges.h` on C++26 (P3168R2)
  (fmtlib/fmt#4761). Thanks @phprus.

- Fixed a GCC PCH breakage triggered by a scoped `#pragma GCC optimize`.

- Fixed a TSAN false positive in the locale handling code
  (fmtlib/fmt#4755).

- Fixed compile-time format string checks truncating string literals at
  an embedded null byte
  (fmtlib/fmt#4732). Thanks @user202729.

- Fixed out-of-bounds reads in `printf` formatting
  (fmtlib/fmt#4741,
  fmtlib/fmt#4742,
  fmtlib/fmt#4800).
  Thanks @Algunenano and @aizu-m.

- Fixed the return type of the `f(un)lockfile`   wrappers on Windows
  (fmtlib/fmt#4739). Thanks @mvastola.

- Worked around a CUDA issue when handling UTF-32 literals
  (fmtlib/fmt#4719). Thanks @Cazadorro.

- Fixed missing named-argument validation for compiled format strings
  (fmtlib/fmt#4638). Thanks @jaeheonshim.

- Fixed `fmt::format_to_n` in `<fmt/compile.h>` failing to compile when
  `<iterator>` is not transitively included
  (fmtlib/fmt#4615).

- Fixed handling of pointers in format string compilation with
  `FMT_BUILTIN_TYPES=0`.

- Stopped assuming nul termination of the format string in `fmt::printf`.
  Thanks @ZUENS2020 for reporting.

- Fixed a build error when locale support is disabled
  (fmtlib/fmt#4627). Thanks @marcel-behlau-elfin.

- Fixed a fallback range formatter for types with a `container_type` member
  (fmtlib/fmt#4123,
  fmtlib/fmt#4660). Thanks @soumik15630m.

- Fixed C++20 concept detection
  (fmtlib/fmt#4653). Thanks @tearfur.

- Fixed a clang compilation failure
  (fmtlib/fmt#4718). Thanks @mccakit.

- Fixed various MSVC warnings, including C4305 and conversion warnings on
  x86 (fmtlib/fmt#4668,
  fmtlib/fmt#4594).
  Thanks @kanren3 and @blizzard4591.

- Updated the Android Gradle Plugin to 9.x
  (fmtlib/fmt#4651,
  fmtlib/fmt#4658). Thanks @soumik15630m.

- Made various code, build and test improvements
  (fmtlib/fmt#4625,
  fmtlib/fmt#4639,
  fmtlib/fmt#4644,
  fmtlib/fmt#4656,
  fmtlib/fmt#4680,
  fmtlib/fmt#4681,
  fmtlib/fmt#4704,
  fmtlib/fmt#4710,
  fmtlib/fmt#4713,
  fmtlib/fmt#4729,
  fmtlib/fmt#4751,
  fmtlib/fmt#4758,
  fmtlib/fmt#4799).
  Thanks @ZephyrLykos, @togunchan, @KaganCanSit, @berndpetrovitsch,
  @Skylion007, @st0rmbtw, @localspook and @EXtremeExploit.

- Improved documentation, including a rewrite of the format string syntax,
  better handling of doxygen tags, documenting `output_file`, fixing CSS so
  that whitespace is displayed properly, and various smaller fixes
  (fmtlib/fmt#4622,
  fmtlib/fmt#4626,
  fmtlib/fmt#4631,
  fmtlib/fmt#4667,
  fmtlib/fmt#4616,
  fmtlib/fmt#4748).
  Thanks @heavywatal, @ZephyrLykos, @user202729, @ssszcmawo, @bigmoonbit
  and @Powerbyte7.

- Added building of release artifacts and SLSA provenance in CI, added a
  CodeQL workflow, and added the security policy in `.github/SECURITY.md`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants