cleanup: remove unused constants in generic xdsclient#8315
Conversation
| - The grpc package should only depend on standard Go packages and a small number | ||
| of exceptions. **If your contribution introduces new dependencies**, you will | ||
| need a discussion with gRPC-Go maintainers. A github action check will run on | ||
| need a discussion with gRPC-Go maintainers. A Github action check will run on |
There was a problem hiding this comment.
Apparently we have a special linter that will want this to be written as GitHub everywhere.
| need a discussion with gRPC-Go maintainers. A Github action check will run on | |
| need a discussion with gRPC-Go maintainers. A GitHub action check will run on |
| func (c *XDSClient) getChannelForADS(serverConfig *ServerConfig, callingAuthority *authority) (*xdsChannel, func(), error) { | ||
| if c.done.HasFired() { | ||
| return nil, nil, ErrClientClosed | ||
| return nil, nil, errClientClosed |
There was a problem hiding this comment.
Given that it's used exactly once, let's just inline it.
The comment on it became stale anyway.
dfawley
left a comment
dfawley
left a comment
There was a problem hiding this comment.
In future, please avoid combining unrelated changes like this.
https://github.com/grpc/grpc-go/blob/master/CONTRIBUTING.md#guidelines-for-pull-requests
- Create small PRs that are narrowly focused on addressing a single concern.
If you wouldn't mind splitting this one up, that would be great, too.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8315 +/- ##
==========================================
- Coverage 82.19% 82.17% -0.03%
==========================================
Files 419 419
Lines 41992 41990 -2
==========================================
- Hits 34516 34504 -12
- Misses 6008 6016 +8
- Partials 1468 1470 +2
🚀 New features to boost your workflow:
|
purnesh42H
changed the title
I have remove the contributing.md change from this PR |
|
Thanks! |
2 participants
RELEASE NOTES: None