Deprecate Entity Apply#6305
Merged
Merged
Conversation
Contributor
|
Agree. I am kind of 👍 for getting rid of over-use of |
rossabaker
reviewed
Apr 18, 2022
rossabaker
left a comment
rossabaker
left a comment
Member
There was a problem hiding this comment.
👍 in principle, but I'm pro-deprecation.
diesalbla
force-pushed
the
avoid_entity_apply
branch
3 times, most recently
from
a19bec5 to
ae5a922
Compare
danicheg
approved these changes
Apr 26, 2022
danicheg
left a comment
danicheg
left a comment
Member
There was a problem hiding this comment.
Despite a few suggestions below, this is great 👍
diesalbla
force-pushed
the
avoid_entity_apply
branch
2 times, most recently
from
0e1c072 to
b4b8864
Compare
diesalbla
force-pushed
the
avoid_entity_apply
branch
2 times, most recently
from
4206bd4 to
2be91aa
Compare
diesalbla
force-pushed
the
avoid_entity_apply
branch
2 times, most recently
from
eb5a798 to
216c7ca
Compare
diesalbla
force-pushed
the
avoid_entity_apply
branch
2 times, most recently
from
dca8a3d to
e9f9b51
Compare
armanbilge
reviewed
Dec 31, 2022
diesalbla
force-pushed
the
avoid_entity_apply
branch
from
e9f9b51 to
46caa95
Compare
danicheg
reviewed
Jan 1, 2023
diesalbla
force-pushed
the
avoid_entity_apply
branch
2 times, most recently
from
230fce9 to
5492a1e
Compare
danicheg
approved these changes
Jan 1, 2023
danicheg
left a comment
danicheg
left a comment
Member
There was a problem hiding this comment.
I want to drop out one bikeshedding about renaming Entity.Default -> Entity.Streamed (or any other that would highlight the streaming nature of that entity). Besides that, this PR makes sense to me!
diesalbla
force-pushed
the
avoid_entity_apply
branch
from
5492a1e to
fa93660
Compare
Member
|
I advise getting one more like before getting this merged. |
rossabaker
reviewed
Jan 1, 2023
rossabaker
left a comment
rossabaker
left a comment
Member
There was a problem hiding this comment.
I like it. But if this merges without a scalafix, providing one should be a separate ticket.
diesalbla
force-pushed
the
avoid_entity_apply
branch
from
fa93660 to
301feeb
Compare
diesalbla
force-pushed
the
avoid_entity_apply
branch
3 times, most recently
from
e5991a3 to
794159f
Compare
diesalbla
force-pushed
the
avoid_entity_apply
branch
2 times, most recently
from
292c55e to
be6a37a
Compare
diesalbla
force-pushed
the
avoid_entity_apply
branch
from
be6a37a to
9771abf
Compare
Since we may want to steer code away from the streamed entities as a default, we should deprecate the Entity.apply method in favour of a explicit `stream` constructor... We also rename the Entity.Default class to Entity.Streamed. Additionally, we add a couple of constructors for strict entities, `string` and `utf8String`.
diesalbla
force-pushed
the
avoid_entity_apply
branch
from
9771abf to
5ff7286
Compare
ChristopherDavenport
approved these changes
Apr 14, 2023
armanbilge
approved these changes
Apr 14, 2023
armanbilge
added a commit
that referenced
this pull request
Apr 14, 2023
armanbilge
added a commit
that referenced
this pull request
Apr 14, 2023
Fix semantic merge conflicts following #6305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
Entity.Streamis not a good default, because of the overhead of dealing with streams, we deprecate the Entity.apply method in favour of a explicitstreamconstructor.We also add a explicit
stringconstructor for strict entities.