more tests

yegor256 · yegor256 · commit 9def0893c62d · 2023-01-16T08:04:27.000+05:00
diff --git a/src/main/java/com/jcabi/xml/ConsoleErrorListener.java b/src/main/java/com/jcabi/xml/ConsoleErrorListener.java
@@ -31,6 +31,7 @@
 
 import com.jcabi.log.Logger;
 import java.util.Collection;
+import java.util.Collections;
 import java.util.concurrent.CopyOnWriteArrayList;
 import javax.xml.transform.ErrorListener;
 import javax.xml.transform.TransformerException;
@@ -84,7 +85,7 @@ public void fatalError(final TransformerException error)
      * @return List of errors accumulated
      */
     public Collection<String> summary() {
-        return this.errors;
+        return Collections.unmodifiableCollection(this.errors);
     }
 
 }
diff --git a/src/main/java/com/jcabi/xml/XSLDocument.java b/src/main/java/com/jcabi/xml/XSLDocument.java
@@ -458,11 +458,17 @@ private void transformInto(final XML xml, final Result result) {
                 trans.transform(new DOMSource(xml.node()), result);
             }
         } catch (final TransformerException ex) {
+            final StringBuilder summary = new StringBuilder(
+                String.join("; ", errors.summary())
+            );
+            if (!summary.toString().equals(ex.getMessageAndLocation())) {
+                summary.append("; ").append(ex.getMessageAndLocation());
+            }
             throw new IllegalArgumentException(
                 String.format(
-                    "Failed to transform by %s: %s (%s)",
+                    "Failed to transform by %s: %s",
                     trans.getClass().getName(),
-                    errors.summary(), ex.getMessageAndLocation()
+                    summary
                 ),
                 ex
             );
diff --git a/src/test/java/com/jcabi/xml/XSLDocumentTest.java b/src/test/java/com/jcabi/xml/XSLDocumentTest.java
@@ -198,10 +198,14 @@ void catchesXslErrorMessages() {
                         "<xsl:message terminate='yes'>",
                         "<xsl:text>oopsie...</xsl:text>",
                         " </xsl:message></xsl:template></xsl:stylesheet>"
-                    )
+                    ),
+                    "foo"
                 ).transform(new XMLDocument("<zz1/>"))
             ).getLocalizedMessage(),
-            Matchers.containsString("Processing terminated by xsl:message")
+            Matchers.allOf(
+                Matchers.containsString("Processing terminated by xsl:message"),
+                Matchers.containsString("by xsl:message at line 1 in foo")
+            )
         );
     }
 

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@`
`31`	`31`
`32`	`32`	`import com.jcabi.log.Logger;`
`33`	`33`	`import java.util.Collection;`
	`34`	`+import java.util.Collections;`
`34`	`35`	`import java.util.concurrent.CopyOnWriteArrayList;`
`35`	`36`	`import javax.xml.transform.ErrorListener;`
`36`	`37`	`import javax.xml.transform.TransformerException;`
`@@ -84,7 +85,7 @@ public void fatalError(final TransformerException error)`
`84`	`85`	`* @return List of errors accumulated`
`85`	`86`	`*/`
`86`	`87`	`public Collection<String> summary() {`
`87`		`- return this.errors;`
	`88`	`+ return Collections.unmodifiableCollection(this.errors);`
`88`	`89`	`}`
`89`	`90`
`90`	`91`	`}`