#105 Add test for empty XSL stylesheet#486
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yegor256 this PR closes #105 by adding the missing regression test for the empty
<xsl:stylesheet>case from the issue.What was missing
XSLDocumentTesthad no coverage for the empty-stylesheet input shown in the issue body:What this adds
A new test
emptyStylesheetExtractsTextContentthat:XSLDocumentfrom the empty stylesheet from the issue.applyTo(...)on<a><b>hello</b><c>world</c></a>.helloworld, which is the documented XSLT behavior: with no template rules defined, the built-in templates traverse the tree and emit text nodes verbatim, so the concatenated text content is the expected result.This pins the documented XSLT default-rules behavior so future regressions in
XSLDocument(e.g. accidentally rejecting an empty stylesheet at construction time, or breaking text extraction) will be caught.Verification
mvn -B clean install -Pqulicepasses locally on Java 21.