Skip to content

Prevent replacing code with find and replace in read-only cells#16682

Merged
krassowski merged 5 commits into
jupyterlab:mainfrom
itsmevichu:Fix-for-find-and-replace-of-read-only-cells
Aug 19, 2024
Merged

Prevent replacing code with find and replace in read-only cells#16682
krassowski merged 5 commits into
jupyterlab:mainfrom
itsmevichu:Fix-for-find-and-replace-of-read-only-cells

Conversation

@itsmevichu

Copy link
Copy Markdown
Member

Fixes #16627

@jupyterlab-probot

Copy link
Copy Markdown

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@itsmevichu itsmevichu marked this pull request as ready for review August 17, 2024 12:22
@krassowski krassowski added this to the 4.2.x milestone Aug 19, 2024

@krassowski krassowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @itsmevichu!

@krassowski krassowski changed the title Disabling find and replace for read-only cells Prevent replacing code with find and replace in read-only cells Aug 19, 2024
@krassowski krassowski merged commit 60aa967 into jupyterlab:main Aug 19, 2024
@krassowski

Copy link
Copy Markdown
Member

@meeseeksdev please backport to 4.2.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Aug 19, 2024
krassowski pushed a commit that referenced this pull request Aug 19, 2024
…ead-only cells (#16696)

Co-authored-by: Vishnutheep B <vishnutheep@gmail.com>
ImpSy pushed a commit to spotinst/jupyterlab that referenced this pull request Jan 7, 2025
…terlab#16682)

* Disabling find-and-replace for read-only cells

* Adding unit test

* lint check
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Find & replace function also replaces text in read-only cells

2 participants