Skip to content

Correct import of date-fns@v3 format#271

Merged
marnusw merged 4 commits into
marnusw:masterfrom
gugu:patch-1
Mar 22, 2024
Merged

Correct import of date-fns@v3 format#271
marnusw merged 4 commits into
marnusw:masterfrom
gugu:patch-1

Conversation

@gugu

@gugu gugu commented Mar 22, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@marnusw

marnusw commented Mar 22, 2024

Copy link
Copy Markdown
Owner

@gugu why did you add the prepare script which is the same as the build script?

@gugu

gugu commented Mar 22, 2024

Copy link
Copy Markdown
Contributor Author

@marnusw usually it allows to install the module from github directly (without waiting for npm). But this time it did not work.

when I run npm install github:user/date-fns-tz#branch it checks out the repo and runs npm prepare to build a package

@gugu

gugu commented Mar 22, 2024

Copy link
Copy Markdown
Contributor Author

@marnusw fixed build as well

@marnusw marnusw merged commit ee1acd7 into marnusw:master Mar 22, 2024
@marnusw

marnusw commented Mar 22, 2024

Copy link
Copy Markdown
Owner

Amazing @gugu, thank you. I have fixed a few more imports and published 3.0.0-beta.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants