Skip to content

date-fns v4.1.0 support#301

Merged
marnusw merged 3 commits into
marnusw:masterfrom
eshimischi:master
Sep 26, 2024
Merged

date-fns v4.1.0 support#301
marnusw merged 3 commits into
marnusw:masterfrom
eshimischi:master

Conversation

@eshimischi

Copy link
Copy Markdown
Contributor

No description provided.

@eshimischi

eshimischi commented Sep 22, 2024

Copy link
Copy Markdown
Contributor Author

@marnusw let's do it when you'll have time, thanks in advanced!

@marnusw marnusw merged commit e7a6122 into marnusw:master Sep 26, 2024
@eshimischi

Copy link
Copy Markdown
Contributor Author

@marnusw thanks for merging! Would you please publish a new version of library to npm?

@marnusw

marnusw commented Sep 26, 2024

Copy link
Copy Markdown
Owner

Ran out of time this morning. I will. 👍🏻

@eshimischi

Copy link
Copy Markdown
Contributor Author

Ran out of time this morning. I will. 👍🏻

Not published yet? https://www.npmjs.com/package/date-fns-tz v3.1.3

@marnusw

marnusw commented Sep 30, 2024

Copy link
Copy Markdown
Owner

v3.2.0

@markedwards

Copy link
Copy Markdown

Just to confirm -- this maintains backwards-compatibility with date-fns 3.x?

@eshimischi

Copy link
Copy Markdown
Contributor Author

Just to confirm -- this maintains backwards-compatibility with date-fns 3.x?

No. You should you use previous version v3.1.3

@markedwards

markedwards commented Oct 5, 2024

Copy link
Copy Markdown

Just to confirm -- this maintains backwards-compatibility with date-fns 3.x?

No. You should you use previous version v3.1.3

Thanks! Probably a good idea to put this in the release notes. And really shouldn't this be v4.0.0 since its a breaking change?

@marnusw

marnusw commented Oct 5, 2024

Copy link
Copy Markdown
Owner

Look at package.json. if support was dropped it would be in the release notes.

@markedwards

markedwards commented Oct 5, 2024

Copy link
Copy Markdown

I understand what's in package.json. I'm being cautious here and making sure there are no caveats to bite us.

@marnusw so you're saying 3.2.0 does still support date-fns 3.x? And @eshimischi is incorrect?

@eshimischi

eshimischi commented Oct 5, 2024

Copy link
Copy Markdown
Contributor Author

I understand what's in package.json. I'm being cautious here and making sure there are no caveats to bite us.

@marnusw so you're saying 3.2.0 does still support date-fns 3.x? And @eshimischi is incorrect?

Of course package has no incompatible changes except peer dependency extended to v4.0.0 of date-fns. My bad for making a confusion. You can use v3.2.0 with date-fns v3

@markedwards

Copy link
Copy Markdown

Got it, thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants