chore: add unit tests for OCIContainer._get_platform_args#2878
Merged
Conversation
While this was already tested indirectly through `test_local_image`, this makes the behaviour check of `OCIContainer._get_platform_args` clear.
agriyakhetarpal
approved these changes
May 31, 2026
henryiii
approved these changes
May 31, 2026
henryiii
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the context of checking one potential issue reported in #2854, I checked if the we could get rid of the
_get_platform_argsworkaround at some point but the issue is still opened.I can only report that the behaviour is now correct without the workaround on macOS with the latest Docker Desktop version, using containerd.
The behaviour of cibuildwheel can likely be different when working using multi-platform images depending on docker configuration. The impact is mostly when doing a qemu driven build and using a moving image tag such as latest: a tag update will trigger a download rather than re-use an already present image. It's probably a niche use-case+configuration combination or it would have already been reported if deemed important.