fix: calendar disabled hover closes: #4253 #4257
Merged
saadeghi merged 1 commit intoNov 6, 2025
Merged
Conversation
Contributor
|
Please, please, fix the content of the PR |
sulimanbenhalim
force-pushed
the
fix-calendar-disabled-hover
branch
from
8b8482b to
b8dc45e
Compare
Contributor
Author
@pdanpdan Give me a minute to fix things before spamming comments |
Owner
|
Have some tea ☕️☕️🫖 @sulimanbenhalim @pdanpdan |
Contributor
|
I would bo with |
Owner
|
@pdanpdan Yes that would be cleaner, but I think it would require adding not in all other states such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #4253
Disabled calendar dates in react-day-picker show hover background color, making them appear interactive when they cannot be clicked which creates confusing UX
Fix
Added CSS rule to remove hover background from disabled date buttons (
:disabled:hoverand[aria-disabled="true"]:hover) and set cursor tonot-allowedTesting
Tested in playground at disabled dates no longer show hover background color