Skip to content

Add SPHINX_AUTOBUILD_DEBUG to aid debugging#192

Merged
AA-Turner merged 4 commits into
sphinx-doc:mainfrom
cmarqu:feat/add-SPHINX_AUTOBUILD_DEBUG
Aug 25, 2025
Merged

Add SPHINX_AUTOBUILD_DEBUG to aid debugging#192
AA-Turner merged 4 commits into
sphinx-doc:mainfrom
cmarqu:feat/add-SPHINX_AUTOBUILD_DEBUG

Conversation

@cmarqu

@cmarqu cmarqu commented May 28, 2025

Copy link
Copy Markdown
Contributor

Currently, changed paths and the ignore expressions are shown.

Closes #188

Currently, changed paths and the ignore expressions are shown.

Closes sphinx-doc#188
@AA-Turner

Copy link
Copy Markdown
Member

Could we add a small test for this? Otherwise looks good.

@cmarqu cmarqu force-pushed the feat/add-SPHINX_AUTOBUILD_DEBUG branch from 7d8d61d to 28928dc Compare August 24, 2025 16:03
@cmarqu

cmarqu commented Aug 24, 2025

Copy link
Copy Markdown
Contributor Author

I added a test.

This highlighted that currently, also SPHINX_AUTOBUILD_DEBUG=0 is considered to mean "print debug output" which might be confusing for users. WDYT?

@AA-Turner

Copy link
Copy Markdown
Member

I agree, the empty string and 0 should probably be falsy.

A

@cmarqu

cmarqu commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

I did this change, but to be really nitpicky, I'd consider the empty string truthy, and extend falsiness to the strings "no" and "false" (case insensitive).

It's surprising that there doesn't seem to be a commonly agreed upon best practice here.

Comment thread sphinx_autobuild/filter.py Outdated
@AA-Turner AA-Turner merged commit 0c52892 into sphinx-doc:main Aug 25, 2025
4 checks passed
@AA-Turner

Copy link
Copy Markdown
Member

Thanks @cmarqu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finding out which files a triggering a rebuild

2 participants