fix corner case in awaits (#5158)

alexlamsl · web-flow · commit eb93d923574d · 2021-10-29T23:33:10.000+08:00
fixes #5157
diff --git a/lib/compress.js b/lib/compress.js
@@ -10334,7 +10334,7 @@ merge(Compressor.prototype, {
                     do {
                         node = parent;
                         parent = compressor.parent(level++);
-                        if (parent instanceof AST_Try && parent.bfinally && parent.bfinally !== node) {
+                        if (parent instanceof AST_Try && member(node, parent.body)) {
                             drop = false;
                             break;
                         }
diff --git a/test/compress/awaits.js b/test/compress/awaits.js
@@ -2046,3 +2046,100 @@ issue_5070: {
     expect_stdout: "PASS"
     node_version: ">=10"
 }
+
+issue_5157_async_function: {
+    options = {
+        awaits: true,
+        side_effects: true,
+    }
+    input: {
+        async function f() {
+            throw "FAIL";
+        }
+        (async function() {
+            try {
+                return await f();
+            } catch (e) {
+                return "PASS";
+            }
+        })().then(console.log);
+    }
+    expect: {
+        async function f() {
+            throw "FAIL";
+        }
+        (async function() {
+            try {
+                return await f();
+            } catch (e) {
+                return "PASS";
+            }
+        })().then(console.log);
+    }
+    expect_stdout: "PASS"
+    node_version: ">=8"
+}
+
+issue_5157_async_iife: {
+    options = {
+        awaits: true,
+        side_effects: true,
+    }
+    input: {
+        (async function() {
+            try {
+                return await async function() {
+                    throw "FAIL";
+                }();
+            } catch (e) {
+                return "PASS";
+            }
+        })().then(console.log);
+    }
+    expect: {
+        (async function() {
+            try {
+                return await async function() {
+                    throw "FAIL";
+                }();
+            } catch (e) {
+                return "PASS";
+            }
+        })().then(console.log);
+    }
+    expect_stdout: "PASS"
+    node_version: ">=8"
+}
+
+issue_5157_promise: {
+    options = {
+        awaits: true,
+        side_effects: true,
+    }
+    input: {
+        var p = new Promise(function(resolve, reject) {
+            reject("FAIL");
+        });
+        (async function() {
+            try {
+                return await p;
+            } catch (e) {
+                return "PASS";
+            }
+        })().then(console.log);
+    }
+    expect: {
+        var p = new Promise(function(resolve, reject) {
+            reject("FAIL");
+        });
+        (async function() {
+            try {
+                return await p;
+            } catch (e) {
+                return "PASS";
+            }
+        })().then(console.log);
+    }
+    expect_stdout: "PASS"
+    node_version: ">=8"
+}

Original file line number	Diff line number	Diff line change
`@@ -10334,7 +10334,7 @@ merge(Compressor.prototype, {`
`10334`	`10334`	`do {`
`10335`	`10335`	`node = parent;`
`10336`	`10336`	`parent = compressor.parent(level++);`
`10337`		`- if (parent instanceof AST_Try && parent.bfinally && parent.bfinally !== node) {`
	`10337`	`+ if (parent instanceof AST_Try && member(node, parent.body)) {`
`10338`	`10338`	`drop = false;`
`10339`	`10339`	`break;`
`10340`	`10340`	`}`