fix(module): always set protocol to https when https: true is set#344
Conversation
|
Hi @blowsie. I fully understand. But as already mentioned dd67734#commitcomment-37868019, If you need https always on, you can already directly set it for |
|
In my experience, non dev environments often use localhost and https. Please do what you will, I was just trying to help. |
|
@blowsie I'm sorry made you feel like that. Features to OSS are added by individual developers. Both
|
|
@pi0 |
|
Yes same for me I run HTTPs locally to test CSP and HTTPS cookies |
https when https: true is set
Codecov Report
@@ Coverage Diff @@
## dev #344 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 30 30
Branches 13 12 -1
=========================================
Hits 30 30
Continue to review full report at Codecov.
|
https when https: true is sethttps when https: true is set
HTTPS on localhost is not possible because of this change.
#93
There is no justification as to why this change has been made.
To me it feels like a developer issue and what should have been done is something along the lines of this in the config.
https: process.env.NODE_ENV === 'development',As it stands at the moments the https setting is redundant in localhost and the limitation is not well documented
https://cmty.app/nuxt/axios-module/issues/c346