Update greek alphabet#1238
Merged
Merged
Conversation
profnandaa
reviewed
Jan 27, 2020
profnandaa
left a comment
profnandaa
left a comment
Member
There was a problem hiding this comment.
Thanks for your contrib 🎉LGTM, could you just address one comment below and we land this?
| validator: 'isAlpha', | ||
| args: ['el-GR'], | ||
| valid: [ | ||
| 'αβγδεζηθικλμνξοπρςστυφχψω', |
Member
There was a problem hiding this comment.
For the tests, could you please add more tests other than overwriting the previous ones?
Contributor
Author
There was a problem hiding this comment.
Added tests instead of overwrite ✅
Girgetto
commented
Jan 27, 2020
Girgetto
left a comment
Girgetto
left a comment
Contributor
Author
There was a problem hiding this comment.
Added tests changes after the last review
| validator: 'isAlpha', | ||
| args: ['el-GR'], | ||
| valid: [ | ||
| 'αβγδεζηθικλμνξοπρςστυφχψω', |
Contributor
Author
There was a problem hiding this comment.
Added tests instead of overwrite ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refers to #1237
Old regex:
/^[Α-ω]+$/iNew regex:
/^[Α-ώ]+$/iThis expanded range now also includes
άέήίΰ(char codes 940 through 944) andϊϋόύώ(codes 970 through 974)Resource:
https://stackoverflow.com/questions/23327302/javascript-regex-to-remove-special-characters-but-also-keep-greek-characters