Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

feat: add get() function#709

Merged
DominicKramer merged 3 commits into
googleapis:masterfrom
DominicKramer:feat/add-get-function
Jun 5, 2019
Merged

feat: add get() function#709
DominicKramer merged 3 commits into
googleapis:masterfrom
DominicKramer:feat/add-get-function

Conversation

@DominicKramer

Copy link
Copy Markdown
Contributor

The get() function is used to access an agent if it
has been started.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 28, 2019
@DominicKramer

Copy link
Copy Markdown
Contributor Author

PR #710 is blocking this PR as it should address the test failures.

@DominicKramer DominicKramer added the status: blocked Resolving the issue is dependent on other work. label May 28, 2019

@ofrobots ofrobots left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green.

@JustinBeckwith JustinBeckwith removed the status: blocked Resolving the issue is dependent on other work. label May 29, 2019
@DominicKramer DominicKramer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 29, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 29, 2019
@DominicKramer

Copy link
Copy Markdown
Contributor Author

This is blocked by PR #713

@DominicKramer DominicKramer added the status: blocked Resolving the issue is dependent on other work. label May 31, 2019
@DominicKramer

DominicKramer commented May 31, 2019

Copy link
Copy Markdown
Contributor Author

This is also blocked by PR #718. After that lands, the tests will pass.

The `get()` function is used to access an agent if it
has been started.
@DominicKramer DominicKramer force-pushed the feat/add-get-function branch from b1ae5a1 to c25a34a Compare June 5, 2019 16:58
@codecov

codecov Bot commented Jun 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #709 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
+ Coverage   85.63%   85.66%   +0.03%     
==========================================
  Files          13       13              
  Lines         947      949       +2     
  Branches      193      193              
==========================================
+ Hits          811      813       +2     
  Misses         75       75              
  Partials       61       61
Impacted Files Coverage Δ
src/index.ts 94.73% <100%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f52b1...6b37a9a. Read the comment docs.

@DominicKramer DominicKramer merged commit 003c662 into googleapis:master Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement. status: blocked Resolving the issue is dependent on other work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants