java-gi/java-gi
1
19
Fork 3
Code Issues 3 Pull requests Releases 34 Activity Actions

Improve Windows support #368

Merged
jwharm merged 5 commits from upcall-w64 into main 2026-05-25 14:18:11 +02:00
Conversation 0 Commits 5 Files changed 14 +204 -110
jwharm commented 2026-05-25 14:11:24 +02:00
Owner
Copy link

This PR fixes issues that were discovered during a test on Windows.

All of the fixes involve long (and unsigned long) values, which are sized as 32-bit on (x86-64) Windows and 64-bit on (x86-64) Linux and macOS.
(See this wikipedia overview, specifically the difference between LLP64 and LP64, for details.) Java-GI uses 64-bit values (ValueLayout.JAVA_LONG) on Linux and macOS, and 32-bit values (ValueLayout.JAVA_INT) on Windows, whenever a long or unsigned long is encountered.

Most of this was already implemented previously, but it contained several bugs, that have now been fixed. Furthermore, callback functions with long/unsigned long parameters or return values now also work correctly (via a upcall_w64() function that is generated in addition to the already existing upcall()). This also works for method overrides.

On the Java side, all long and unsigned long parameter- and return-types are represented as int, which is the largest common denominator for all three supported platforms.

This PR shouldn't introduce any breaking changes in the API.

This PR fixes issues that were discovered during a test on Windows. All of the fixes involve `long` (and `unsigned long`) values, which are sized as 32-bit on (x86-64) Windows and 64-bit on (x86-64) Linux and macOS. (See [this wikipedia overview](https://en.wikipedia.org/wiki/64-bit_computing#64-bit_data_models), specifically the difference between LLP64 and LP64, for details.) Java-GI uses 64-bit values (`ValueLayout.JAVA_LONG`) on Linux and macOS, and 32-bit values (`ValueLayout.JAVA_INT`) on Windows, whenever a `long` or `unsigned long` is encountered. Most of this was already implemented previously, but it contained several bugs, that have now been fixed. Furthermore, callback functions with `long`/`unsigned long` parameters or return values now also work correctly (via a `upcall_w64()` function that is generated in addition to the already existing `upcall()`). This also works for method overrides. On the Java side, all `long` and `unsigned long` parameter- and return-types are represented as `int`, which is the largest common denominator for all three supported platforms. This PR shouldn't introduce any breaking changes in the API.
These check for specific values that will be different depending on the
platform, so only run them on Linux/macOS for now.
jwharm merged commit 7e3c41c62a into main 2026-05-25 14:18:11 +02:00
jwharm deleted branch upcall-w64 2026-05-25 14:18:12 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
github_actions
Pull requests that update GitHub Actions code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
java
Pull requests that update Java code

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
java
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
java-gi/java-gi!368
No description provided.