java-gi/java-gi
1
19
Fork 3
Code Issues 3 Pull requests Releases 34 Activity Actions

Fix a double-free in GList/GSList #370

Merged
jwharm merged 2 commits from fix-list-double-free into main 2026-06-10 22:18:50 +02:00
Conversation 0 Commits 2 Files changed 11 +190 -91
jwharm commented 2026-06-10 22:10:06 +02:00
Owner
Copy link

When a GList or GSList contains GObjects, a double free bug makes the application segfault: The lifetime of the elements is managed by the InstanceCache, but the list tries to free them anyway.

The fix is to not free GObject elements. This was difficult to implement because, thanks to Java generic type erasure, we don't know the element type at runtime. So the GList and GSList constructors now take a GType argument, so we know the type.

When a GList or GSList contains GObjects, a double free bug makes the application segfault: The lifetime of the elements is managed by the InstanceCache, but the list tries to free them anyway. The fix is to not free GObject elements. This was difficult to implement because, thanks to Java generic type erasure, we don't know the element type at runtime. So the GList and GSList constructors now take a GType argument, so we know the type.
When a GList or GSList contains GObjects, a double free bug makes the
application segfault: The lifetime of the elements is managed by the
InstanceCache, but the list tries to free them anyway.

The fix is to not free GObject elements. This was difficult to
implement because, thanks to Java generic type erasure, we don't know
the element type at runtime. So the GList and GSList constructors now
take a GType argument, so we know the type.
This adds the old constructors back, annotated as deprecated.
They will be removed in a future java-gi release.
jwharm merged commit 31e086e693 into main 2026-06-10 22:18:50 +02:00
jwharm deleted branch fix-list-double-free 2026-06-10 22:18:57 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
github_actions
Pull requests that update GitHub Actions code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
java
Pull requests that update Java code

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
java
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
java-gi/java-gi!370
No description provided.