Skip to content

missing dev dependencies for eslint-plugin-jsdoc, @typescript-eslint/parser and @typescript-eslint/eslint-plugin#62

Merged
Ayfri merged 1 commit into
Advanced-Command-Handler:docsfrom
Dergash:fix/missing-dependencies
Jan 24, 2021
Merged

missing dev dependencies for eslint-plugin-jsdoc, @typescript-eslint/parser and @typescript-eslint/eslint-plugin#62
Ayfri merged 1 commit into
Advanced-Command-Handler:docsfrom
Dergash:fix/missing-dependencies

Conversation

@Dergash

@Dergash Dergash commented Jan 24, 2021

Copy link
Copy Markdown
Contributor

While reproducing TypeStrong/typedoc#1480 I've noticed that project didn't launch to me; it seems a couple of dependencies are used in your package.json but are not declared as dependencies and aren't installed during install stage, leading to errors like:

C:\projects\Advanced-Command-Handler>yarn lint
yarn run v1.22.10
$ eslint src/**/*.ts --fix

Oops! Something went wrong! :(

ESLint: 7.18.0

Error: Failed to load parser '@typescript-eslint/parser' declared in 'package.json': Cannot find module '@typescript-eslint/parser'

This PR adds missing dependencies

…nt/parser` and `@typescript-eslint/eslint-plugin`
@Ayfri Ayfri self-requested a review January 24, 2021 02:22

@Ayfri Ayfri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I forgot to add these, thanks!

@Ayfri Ayfri merged commit 732cc27 into Advanced-Command-Handler:docs Jan 24, 2021
@Dergash Dergash deleted the fix/missing-dependencies branch January 24, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants