Skip to content

fix: stop assuming NUL-terminated input from DimRpcParallel::getString() #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sy-c merged 1 commit into from
Feb 6, 2026
Merged

fix: stop assuming NUL-terminated input from DimRpcParallel::getString() #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/DimServices/DimServices.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,15 @@ inline void rtrim(std::string &s) {

void StringRpcServer::rpcHandler()
{
alfDebugLog.info("Request received on %s : %s",mServiceName.c_str(),getString());
// build a safe string from DIM input. Parent method getString() is unsafe, not guarateed to be nul-terminated
std::string inputString;
if (auto data = getString(); data && getSize() > 0) {
inputString.assign(data, getSize());
}

alfDebugLog.info("Request received on %s : %s",mServiceName.c_str(),inputString.c_str());
try {
auto returnValue = mCallback(std::string(getString()));
auto returnValue = mCallback(inputString);
setDataString(makeSuccessString(returnValue), *this);
rtrim(returnValue);
alfDebugLog.info("Request completed: %s", returnValue.c_str());
Expand Down