Attach permission-request to specific fragment#1150
Conversation
allow a fragment to be added as permission-anchor
cortinico
left a comment
There was a problem hiding this comment.
I would opt for having only the Int and Fragment overload and skip the ID approach at least for now.
Also @paolorotolo what's your take on this change?
As far as i can tell, fragments don't have an identifier. So this id is required to differentiate between each fragment for the permissionMap.
Sure, i can make the "String"-one private, but it is still internally required, so it cant be removed. |
In the method that accepts the There is no need to have extra index at all IMHO |
Oh yeah, that is actually better! |
|
I have added a check and a small convenience wrapper that combines the addSlide and askForPermission-calls. |
fixes #1149
This switches permissionsMap to have a string index.
Then instead of the slide-id we use a tag (or id) to figure out if a request should be made
Todo: