Fall back to NIO instead of throwing when no native transport is available#2209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
When
useNativeTransport=truebut no native transport can be loaded (Windows, a minimal image, or missing/failed native libs),getNativeTransportFactorythrewIllegalArgumentExceptionand hard-failed client construction.Modification:
Fall back to the always-available NIO transport in that case, logging once at WARN, instead of throwing. The shipped default (
useNativeTransport=false) and the config-timeuseOnlyEpollNativeTransportvalidation are unchanged.Result:
Requesting native transport never fails client construction; native is still selected when available, and absence degrades gracefully to NIO. Verified both paths on JDK 11 (native present, and forced off via -Dio.netty.transport.noNative=true).