Use regular __CLASS_NAME__ to getParamCode.#233
Closed
warownia1 wants to merge 1 commit into
Closed
Conversation
Method names use non-dollar variant of their parameter names in their name even if inner types are used e.g. myMethod$org_example_Outer_Inner. Clazz._getParamCode was using a $-separated type name resulting in invalid method names produced by java.reflect tools. Fix BobHanson#232
Owner
|
This would revert to prior to commit e5b4842 // BH 2020.07.27 fix for inner class array names I will check. Please provide the Java code snippet illustrating the problem. |
BobHanson
reviewed
Sep 8, 2022
BobHanson
left a comment
BobHanson
left a comment
Owner
There was a problem hiding this comment.
correct file to change is j2sClazz.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method names use non-dollar variant of their parameter names in their name even if inner types are used e.g. myMethod$org_example_Outer_Inner. Clazz._getParamCode was using a $-separated type name resulting in invalid method names produced by java.reflect tools.
THIS CHANGE IS UNTESTED
Please review and test this change. I'm not sure what other places getParamCode was used at that this change might break.
Fix #232