Parallel draw command buffer filling#3783
Closed
ExodusCoder9 wants to merge 1 commit into
Closed
Conversation
…this will help frametimes and also shift some work off the main thread.
Contributor
|
I'm not in favor of introducing threading into this highly latency sensitive part of the render loop. |
Contributor
Author
|
okay understand your concern |
Contributor
|
If you put your suggestions in our dev channel before you put effort into writing PRs we can tell you whether they would get accepted beforehand. I applaud the initiative though. |
Contributor
Author
|
okay ,will do from now on thanks for the feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically , this parallelizes draw command buffer filling , mostly did it to shift some work off the main thread , used a forkjoinpool , i profiled in jfr and it shaved off almost 0.7ms off of main thread cpu time , worth it for me for me personally as its a small change. set cores max as 4 because more would probably give vanishing returns because context switching might then take more time than the task does now. also made the hash map concurrent just to avoid any reading of stale data if new code needs it.