Remove extra ABGR conversion fixes #3779#3798
Merged
Merged
Conversation
Contributor
|
Can you check that this does not regress 5c4771f ? |
Contributor
Author
|
It shouldn't regress that. I used the command from #3726 and tested the glow of the bell with my fix, and it glows red like it is supposed to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3779
Remove extra "ColorARGB.toABGR()" conversion in the non-terrain block render context.
I can't reproduce the color issue from #3779 with this new fix, so it seems good.