Skip to content

Sync ErrorCodes.cpp to avoid conflicts#107742

Open
Avogar wants to merge 1 commit into
masterfrom
Avogar-patch-8
Open

Sync ErrorCodes.cpp to avoid conflicts#107742
Avogar wants to merge 1 commit into
masterfrom
Avogar-patch-8

Conversation

@Avogar

@Avogar Avogar commented Jun 17, 2026

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

...

@clickhouse-gh

clickhouse-gh Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Workflow [PR], commit [470bc07]

Summary:

job_name test_name status info comment
Performance Comparison (arm_release, master_head, 3/6) FAIL Performance dashboard
arithmetic #24::old FAIL query history
arithmetic #24::new FAIL query history
arithmetic #31::old FAIL query history
arithmetic #31::new FAIL query history
arithmetic #32::old FAIL query history
arithmetic #32::new FAIL query history
file_table_function #3::old FAIL query history
file_table_function #3::new FAIL query history
file_table_function #13::old FAIL query history
file_table_function #13::new FAIL query history
18 more test cases not shown

AI Review

Summary
  • This PR reserves STATELESS_WORKER_DISCOVERY_ERROR as error code 775 in src/Common/ErrorCodes.cpp to keep the central error-code list synchronized. I found no correctness, compatibility, or safety issue in the change; Not for changelog is appropriate for this internal bookkeeping.
Final Verdict
  • Status: ✅ Approve

@clickhouse-gh clickhouse-gh Bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 17, 2026
@Algunenano Algunenano self-assigned this Jun 17, 2026
@clickhouse-gh

clickhouse-gh Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

LLVM Coverage Report

Metric Baseline Current Δ
Lines 85.20% 85.20% +0.00%
Functions 92.30% 92.30% +0.00%
Branches 77.50% 77.40% -0.10%

Changed lines: Changed C/C++ lines covered by tests: 7/7 (100.00%) | Lost baseline coverage: none · Uncovered code

Full report · Diff report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants