test: add rows_read accounting and silent-failure regression tests#44
Open
Coding-Dev-Tools wants to merge 2 commits into
Open
test: add rows_read accounting and silent-failure regression tests#44Coding-Dev-Tools wants to merge 2 commits into
Coding-Dev-Tools wants to merge 2 commits into
Conversation
- Add protobuf>=7.34.1 as core dependency (was optional 'full' extra) - Update pytest to >=9.1.0 (was 9.0.3) - Update ruff to >=0.15.20 (was 0.4.0) - Remove 'full' extra since protobuf is now core All 130 tests pass and ruff checks pass.
Regression coverage for the bug where convert() declared rows_read on ConversionResult but never populated it (always 0), and where a conversion that read rows yet wrote none was reported as success.
🤖 Automated Code Review✅ Ruff Lint — No issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add regression tests for
ConversionResult.rows_readaccounting and silent-failure detection.Changes
tests/test_rows_read_accounting.py: Tests thatconvert()properly populatesrows_readand that conversions which read rows but wrote none are not reported as success.Testing
CI will run test/coverage/security jobs on this branch.