move rest-only access into corelib#2308
Merged
Merged
Conversation
VelvetToroyashi
left a comment
Member
There was a problem hiding this comment.
At a glance, looks fine. Are there any other changes intended for this PR?
Plerx2493
approved these changes
May 4, 2025
Plerx2493
approved these changes
May 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deletes DSharpPlus.Rest and instead moves its feature set into DSharpPlus
this is a first step towards properly enabling OAuth2 usage, and more clean-up, documentation and polishing will be needed. it also reduces the maintenance effort required for raw rest access, since we no longer have to keep DSharpPlus.Rest up to date (which it wasn't).
the default logger ignores HttpClient logging spam entirely, and users using 3rd party loggers will have to set log level overrides.