Skip to content

DSharpPlus.Voice#2404

Open
akiraveliara wants to merge 127 commits into
masterfrom
voice-rewrite
Open

DSharpPlus.Voice#2404
akiraveliara wants to merge 127 commits into
masterfrom
voice-rewrite

Conversation

@akiraveliara

@akiraveliara akiraveliara commented Dec 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

the initial pull request for DSharpPlus.Voice.

closes #768
closes #2385

todo:

  • receive
  • audio packet queuing for sending
  • reconnecting/resuming
  • rewire encoding to take advantage of opus' 24-bit and float support instead of (not very costly, but absolutely unreadable) normalization to 16-bit
  • user interface for sending/receiving audio
  • use a more sophisticated mechanism for audio enqueuing than Channel
  • reduce memory management overhead
  • handle RTCP packets
  • correctly track and send RTCP information
  • docs
  • metrics
  • handle channel moves
  • allow ingesting ogg/opus files directly. this would probably be good to have in the initial PR so that users updating immediately get the most efficient behaviour for ogg/opus files

open questions:

  • is it relevant that if we don't receive a user's SSRC in time, we can't decrypt their audio? do we have to buffer those frames?

akiraveliara and others added 30 commits June 6, 2025 18:43
@akiraveliara
start by obsoleting VoiceNext
96a8a62
@akiraveliara
Squashed 'lib/libaerith/inc/dave/' content from commit 6e5ffbc1
46ea60c 
git-subtree-dir: lib/libaerith/inc/dave
git-subtree-split: 6e5ffbc1cb4eef6be96e8115c4626be598b7e501
@akiraveliara
Merge commit '46ea60c33670437abd5c972d66d37ac7ff15fe5b' as 'lib/libae…
89c22cb 
…rith/inc/dave'
@akiraveliara
merge master
ec541bb
@akiraveliara
remove the vnext project from the solution
154574c
@akiraveliara
push preliminary session binding code
f714bd9 
still missing some methods, but
@akiraveliara
add Session::ProcessProposals
1f73350
@akiraveliara
add Session::GetMarshalledKeyPackage
4c76392
@akiraveliara
wrap RosterMap and add bindings to c# for the remaining methods
1827887
@akiraveliara
wrap the c++ into (relatively) usable c#
69d40af 
also makes the c++ nicer to interface with
and also fully delete vnext, not sure why it was still there
@akiraveliara
nulls mean "nothing of note happened" in this case
7fd252f
@akiraveliara
remove the in-tree native in favour of dsharpplus/libkoana
d71296f
@akiraveliara
retarget the MLS interop
8af34b1
@akiraveliara
avoid the mistakes of our ancestors
1319b85 
voicenext used the sodium status code as a length lmao
@akiraveliara
implement the sodium cryptors
f50b973
@akiraveliara
add opus interop bindings
3920c3b
@akiraveliara
Merge remote-tracking branch 'origin/master' into voice-rewrite
5f7ddac
@akiraveliara
implement the opus binding layer
6546f99
@akiraveliara
rewrite the self-building guide
08cf10b
@akiraveliara
add audio buffer pooling capability
0c9719c
@akiraveliara
implement opus encoders and decoders
247d435
@RoniRaad
added media transport service
c617e67
@RoniRaad
updated memory type for writing to media transport service.
68b541f
@RoniRaad
Added xmldocs
c6916aa
@akiraveliara
Merge pull request #2363 from RoniRaad/voice-rewrite-features/media-t…
bbbc1d1 
…ransport

added media transport service
@akiraveliara
add an e2ee session wrapper, move the udp transport code, throw out v…
96349c1 
…4-era networking plumbing
@RoniRaad
Initial commit for transport service.
b36df43
@RoniRaad
Fixed naming convention and binary opCode parsing for DiscordTranspor…
5bc3555 
…tService. Changed TransportService to use ArrayPoolBufferWriter instead of MemoryStream.
@RoniRaad
Discord Transport Service cleanup.
5c8a990
@akiraveliara
Merge pull request #2364 from RoniRaad/voice-rewrite-features/transpo…
50ae74f 
…rt-service

Initial commit for transport service.
@akiraveliara
voice bugfixes, round 5
67e5e4b
@akiraveliara
Merge commit '315e4db1d3b05de63d2d20edf2edfc1151749c1e' into voice-re…
0bd4021 
…write
@akiraveliara
Merge commit '3679bfa37a04991c89ebd716be35f5e60ceaee9c' into voice-re…
aadab9c 
…write
@akiraveliara
add metrics and decryption bugfixes
db6cd98
@akiraveliara
specify correct sample count and pad too-short pcm submissions
ff96407
@akiraveliara
fix double arraypool return, missing flushes and incorrect rtp timescale
d44f271
@akiraveliara
fix incorrect max encrypted frame size
17908c7
@akiraveliara
fix the send loop failing when attempting to send audio without local…
df00366 
… crypto state
@akiraveliara
fix dave state handling around sessions being emptied
96a907a
@akiraveliara
don't waste bandwidth sending to an empty channel
17780be
@akiraveliara
record when a received audio frame fails decryption
1061cc1
@akiraveliara
add an ogg/opus audio writer
0b7e709
@akiraveliara
update copyright year
027e012
@akiraveliara
fix disconnecting requiring the MUTE_MEMBERS permission
307b88a
@akiraveliara
make the channel id on voice state updates optional
91ce1f7
@akiraveliara
fix opus repacketizer crashing when using AudioType.Music
1ee84d3
@akiraveliara
rip out infrastructure for 120ms packets, discord only supports 20ms
8876fc3
@akiraveliara
rip out repacketizer interop too
8a9f569
@akiraveliara
rip the repacketizer out of the encoder as well
c9cadee
@akiraveliara
handle being moved between channels
08eaf67
@akiraveliara
line-wise staging, my nemesis
2ea34d4
@akiraveliara
document bitrate limitations and don't kill the main gateway when dis…
19254d8 
…connecting
@akiraveliara
add a catchup loop to sending audio if we're delayed
ba9e585
@akiraveliara
remove erroneous debug code
d45ac8a
@akiraveliara
track when we've caught back up to realtime
84ae4fc
@akiraveliara
fix silence detection never recovering if audio is streamed in realtime
2abfbac
@akiraveliara
make the audio sending loop more resistant to jittering
04e656c
@akiraveliara
remove a stray debug instruction
69037ea
@akiraveliara
improve codegen for widening mono to stereo
ef648de
@akiraveliara akiraveliara marked this pull request as ready for review June 6, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Plerx2493 Plerx2493 Awaiting requested review from Plerx2493

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

big-change enhancement new-features voice voicenext

Projects

None yet

Milestone

v5.0

Development

Successfully merging this pull request may close these issues.

No audio output from the bot Add ability to send opus data through with Voice

3 participants

@akiraveliara @Plerx2493 @RoniRaad