New DFDs for privacy and industrial cases papers#311
Conversation
Nicolas-Boltz
left a comment
Nicolas-Boltz
left a comment
There was a problem hiding this comment.
Please add a little readme file for each individual case study, with a link to the paper where it originates and maybe with a couple of sentences that describe the system in a very high level.
Also could you move the variations of the cwa model into one folder? so it is scenarios/cwa/noviolation, and accordingly for both violation variants.
Entenwilli
left a comment
Entenwilli
left a comment
There was a problem hiding this comment.
The models look very good, well done!
I really like the VW case study model, because it is very detailed (showing that our DFDs can model more low level stuff) and also has lots of constraints that provide a good picture over the several things that did go wrong
Some smaller, more general notes:
- Naming of edges should be consistent: Like using snake_case
- Naming of nodes should be consistent: Using Title Case
There was a problem hiding this comment.
Some project files were modified with some information, that is related to a java language server.
This should not be present in the repo
|
@manuelcorcoles There are still valid changes requested by @Entenwilli, could you please address them so we can merge this? |
Entenwilli
left a comment
Entenwilli
left a comment
There was a problem hiding this comment.
Some smaller comments, only have to do with naming of files and some remainder.
The models are very good, the level of detail is amazing
Entenwilli
left a comment
Entenwilli
left a comment
There was a problem hiding this comment.
As the other comments from me has been resolved, looks good to me!
3 participants
Korrektur von CWA and VW Constraints.
Neue DFDs aus dem Model-Driven Privacy Paper (https://www.research-collection.ethz.ch/handle/20.500.11850/641986): Minitwit, CMA und Hippa Apps
Neue DFDs aus dem Categorization of Finding security threat Paper (https://www.sciencedirect.com/science/article/pii/S016412122100100X?via%3Dihub): HIL testing und ECU update Apps