fix(results): preserve configured git identity#1484
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
3463058
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://827c098b.agentv.pages.dev |
| Branch Preview URL: | https://fix-results-git-author-fallb.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Results publishing now uses the configured git identity first instead of writing
AgentV Results <agentv@results-repo>into repository config. When git reports that no author or committer identity is configured, AgentV retries only that commit command with its fallback identity through per-command environment variables, leaving the user's local git config unchanged.The git subprocess environment now keeps noninteractive auth hooks such as
GIT_ASKPASS,GIT_USERNAME,GIT_PASSWORD,GIT_TOKEN, andGIT_SSH_COMMAND, while still stripping repo-state variables likeGIT_DIRandGIT_WORK_TREE. The deterministic results-branch genesis commit still uses the fixed AgentV identity, but only through per-command env.Testing
bunx biome check packages/core/src/evaluation/results-repo.ts packages/core/test/evaluation/results-repo.test.tsgit diff --checkbun --filter @agentv/core typecheckbun --filter @agentv/core test test/evaluation/results-repo.test.ts(41 pass)Post-Deploy Monitoring & Validation
No additional production monitoring required; this is local git commit plumbing for result publication. Healthy signals are result commits authored by the configured repo/environment identity when present, fallback
AgentV Results <agentv@results-repo>authors only in no-identity environments, and no writes togit config user.nameorgit config user.email. Failure signals are new result PRs or result branches unexpectedly authored by AgentV despite configured identity, or missing-identity publish failures in clean CI containers. Validation window: next AgentV results-publish run or CI exercise ofresults-repo.test.ts; owner: AgentV maintainers.