Skip to content

fix(results): preserve configured git identity#1484

Merged
christso merged 1 commit into
mainfrom
fix/results-git-author-fallback
Jun 22, 2026
Merged

fix(results): preserve configured git identity#1484
christso merged 1 commit into
mainfrom
fix/results-git-author-fallback

Conversation

@christso

Copy link
Copy Markdown
Collaborator

Summary

Results publishing now uses the configured git identity first instead of writing AgentV Results <agentv@results-repo> into repository config. When git reports that no author or committer identity is configured, AgentV retries only that commit command with its fallback identity through per-command environment variables, leaving the user's local git config unchanged.

The git subprocess environment now keeps noninteractive auth hooks such as GIT_ASKPASS, GIT_USERNAME, GIT_PASSWORD, GIT_TOKEN, and GIT_SSH_COMMAND, while still stripping repo-state variables like GIT_DIR and GIT_WORK_TREE. The deterministic results-branch genesis commit still uses the fixed AgentV identity, but only through per-command env.

Testing

  • bunx biome check packages/core/src/evaluation/results-repo.ts packages/core/test/evaluation/results-repo.test.ts
  • git diff --check
  • bun --filter @agentv/core typecheck
  • bun --filter @agentv/core test test/evaluation/results-repo.test.ts (41 pass)

Post-Deploy Monitoring & Validation

No additional production monitoring required; this is local git commit plumbing for result publication. Healthy signals are result commits authored by the configured repo/environment identity when present, fallback AgentV Results <agentv@results-repo> authors only in no-identity environments, and no writes to git config user.name or git config user.email. Failure signals are new result PRs or result branches unexpectedly authored by AgentV despite configured identity, or missing-identity publish failures in clean CI containers. Validation window: next AgentV results-publish run or CI exercise of results-repo.test.ts; owner: AgentV maintainers.


Compound Engineering
GPT-5

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying agentv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3463058
Status: ✅  Deploy successful!
Preview URL: https://827c098b.agentv.pages.dev
Branch Preview URL: https://fix-results-git-author-fallb.agentv.pages.dev

View logs

@christso christso marked this pull request as ready for review June 22, 2026 11:08
@christso christso merged commit 4b8f0ae into main Jun 22, 2026
8 checks passed
@christso christso deleted the fix/results-git-author-fallback branch June 22, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant