Skip to content

refactor: remove private Phoenix adapter package#1486

Merged
christso merged 1 commit into
mainfrom
refactor/remove-phoenix-adapter-package
Jun 22, 2026
Merged

refactor: remove private Phoenix adapter package#1486
christso merged 1 commit into
mainfrom
refactor/remove-phoenix-adapter-package

Conversation

@christso

Copy link
Copy Markdown
Collaborator

Summary

AgentV no longer carries the private Phoenix adapter experiment as a workspace package. The package was private, unpublished, absent from the release publish list, and conflicted with the current Phoenix boundary: AgentV artifacts stay local/Git-backed, while Phoenix is only optional link-out context for independently emitted traces.

This removes packages/phoenix-adapter, drops the adapter from root build/typecheck/test scripts and CI smoke coverage, and refreshes bun.lock so the Phoenix/Arize dependency chain is no longer installed. It also updates stale ADR/plan language so future work does not revive Phoenix as an AgentV dataset, experiment, result, trace, or storage projection path.

Verification

  • bun install
  • bun run build
  • bun run typecheck
  • bun run lint
  • bun run test
  • bun scripts/validate-eval-dirs.ts
  • bun apps/cli/dist/cli.js validate 'examples/features/**/evals/**/*.eval.yaml' 'examples/features/**/*.EVAL.yaml'
  • git diff --check
  • bun install --frozen-lockfile --dry-run
  • rg checks for stale @agentv/phoenix-adapter, packages/phoenix-adapter, root Phoenix smoke script, and package export symbols
  • Read-only review agents checked dependency/workspace safety, CI/release/testing risk, and Phoenix product-boundary docs; docs findings were addressed before commit

Risk

The supported Phoenix link-out path remains intact through external_trace metadata and Dashboard URL sanitization. The main residual risk is a private internal workflow that imported the deleted workspace package by path; that package was marked private: true, was not published to npm, and was not in the release package list.

Post-Deploy Monitoring & Validation

No additional production monitoring required because this removes an unpublished private workspace package and CI-only smoke path. Validate through GitHub Actions on the PR:

  • Logs to watch: CI Install dependencies, Build packages, Typecheck packages, Run tests, and Validate Evals for missing @agentv/phoenix-adapter workspace/filter errors.
  • Healthy signals: frozen install succeeds, root build/typecheck/test scripts do not reference the deleted workspace, eval schema validation remains green.
  • Failure signals: bun --filter @agentv/phoenix-adapter errors, lockfile frozen-install failures, or imports resolving to the deleted package.
  • Mitigation trigger: if CI or review identifies a still-supported consumer, revert this deletion and replace it with a deprecation/removal plan.
  • Validation window/owner: PR author watches initial PR CI run through completion.

Compound Engineering
Codex

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying agentv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1c4d804
Status: ✅  Deploy successful!
Preview URL: https://5d88fe37.agentv.pages.dev
Branch Preview URL: https://refactor-remove-phoenix-adap.agentv.pages.dev

View logs

@christso christso marked this pull request as ready for review June 22, 2026 11:53
@christso christso merged commit 93fc317 into main Jun 22, 2026
10 checks passed
@christso christso deleted the refactor/remove-phoenix-adapter-package branch June 22, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant