refactor: remove private Phoenix adapter package#1486
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
1c4d804
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5d88fe37.agentv.pages.dev |
| Branch Preview URL: | https://refactor-remove-phoenix-adap.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentV no longer carries the private Phoenix adapter experiment as a workspace package. The package was private, unpublished, absent from the release publish list, and conflicted with the current Phoenix boundary: AgentV artifacts stay local/Git-backed, while Phoenix is only optional link-out context for independently emitted traces.
This removes
packages/phoenix-adapter, drops the adapter from root build/typecheck/test scripts and CI smoke coverage, and refreshesbun.lockso the Phoenix/Arize dependency chain is no longer installed. It also updates stale ADR/plan language so future work does not revive Phoenix as an AgentV dataset, experiment, result, trace, or storage projection path.Verification
bun installbun run buildbun run typecheckbun run lintbun run testbun scripts/validate-eval-dirs.tsbun apps/cli/dist/cli.js validate 'examples/features/**/evals/**/*.eval.yaml' 'examples/features/**/*.EVAL.yaml'git diff --checkbun install --frozen-lockfile --dry-runrgchecks for stale@agentv/phoenix-adapter,packages/phoenix-adapter, root Phoenix smoke script, and package export symbolsRisk
The supported Phoenix link-out path remains intact through
external_tracemetadata and Dashboard URL sanitization. The main residual risk is a private internal workflow that imported the deleted workspace package by path; that package was markedprivate: true, was not published to npm, and was not in the release package list.Post-Deploy Monitoring & Validation
No additional production monitoring required because this removes an unpublished private workspace package and CI-only smoke path. Validate through GitHub Actions on the PR:
Install dependencies,Build packages,Typecheck packages,Run tests, andValidate Evalsfor missing@agentv/phoenix-adapterworkspace/filter errors.bun --filter @agentv/phoenix-adaptererrors, lockfile frozen-install failures, or imports resolving to the deleted package.