Skip to content

fix(healthcare): remove old healthcare java dependency region tag PR Step 2/2#10282

Closed
Kef131 wants to merge 2 commits into
mainfrom
fix(healthcare)-rename_reuse_healthcare_region_tag
Closed

fix(healthcare): remove old healthcare java dependency region tag PR Step 2/2#10282
Kef131 wants to merge 2 commits into
mainfrom
fix(healthcare)-rename_reuse_healthcare_region_tag

Conversation

@Kef131

@Kef131 Kef131 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes b/383619440

Remove old region tag dependencies to healthcare_java_dependencies in healthcare/v1/pom.xml.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required (Requires running gcert first to authenticate with Airlock to resolve dependencies)
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples. api: healhcare labels Jun 17, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 17, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the region tags in healthcare/v1/pom.xml from dependencies to healthcare_java_dependencies and reorganizes some dependency declarations. The feedback points out that a duplicate pair of healthcare_java_dependencies region tags was introduced at the end of the file, which could cause parsing errors in the documentation pipeline, and should be removed.

Comment thread healthcare/v1/pom.xml
Comment on lines +111 to +113
<!-- [START healthcare_java_dependencies] -->
</dependencies>
<!-- [END dependencies] -->
<!-- [END healthcare_java_dependencies] -->

@gemini-code-assist gemini-code-assist Bot Jun 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This second pair of healthcare_java_dependencies region tags is redundant and creates a duplicate region tag definition in the same file. Duplicate region tags can cause parsing errors or incorrect snippet generation in the documentation pipeline. Since the first block (lines 56-75) already defines this region, this second pair should be removed.

  </dependencies>

@Kef131 Kef131 closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver will be requested when the pull request is marked ready for review yoshi-approver is a code owner

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: healhcare api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Kef131