Bump nodejs22 to 22.5.0#1626
Closed
omBratteng wants to merge 1 commit into
Closed
Conversation
loosebazooka
approved these changes
Jul 19, 2024
Collaborator
Author
|
@loosebazooka the report diff keeps failing on PRs made by contributors outside the GoogleContainerTools org. If you update the workflow so that it has write permissions to pull_request, it should no longer fail for external contributors. |
Contributor
|
Note that you will have to wait a while to merge this change: nodejs/node#53934 |
Collaborator
Author
|
I guess we probably can skip this version, and wait for a patched version, 22.5.1 probably. |
Member
Yeah this was more to detect issues on large scale changes we were doing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.