Add Path.Lookup#70
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 43.98% 44.97% +0.99%
==========================================
Files 40 43 +3
Lines 2626 2679 +53
Branches 362 367 +5
==========================================
+ Hits 1155 1205 +50
- Misses 1372 1375 +3
Partials 99 99
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
How is this different from build-in |
Collaborator
Author
|
@zjklee So a change could be like: using HandlebarsDotNet.PathStructure;
namespace HandlebarsDotNet.Helpers
{
public sealed class LookupReturnHelperDescriptor : IHelperDescriptor<HelperOptions>
{
public PathInfo Name { get; } = "lookup";
public object Invoke(in HelperOptions options, in Context context, in Arguments arguments)
{
if (arguments.Length != 2 && arguments.Length != 3)
{
throw new HandlebarsException("{{lookup}} helper must have two or three arguments");
}
var segment = ChainSegment.Create(arguments[1]);
var defaultValueIfNotFound = arguments.Length == 3 ? arguments[2] : UndefinedBindingResult.Create(segment);
return !options.TryAccessMember(arguments[0], segment, out var value)
? defaultValueIfNotFound
: value;
}
public void Invoke(in EncodedTextWriter output, in HelperOptions options, in Context context, in Arguments arguments)
{
output.Write(Invoke(options, context, arguments));
}
}
} |
Member
|
@StefH , looks good to me 🙂 |
Collaborator
Author
|
@zjklee Shall I create a PR for Handlebars.Net ? |
Collaborator
Author
|
@zjklee See PR Handlebars-Net/Handlebars.Net#542 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.