proposed fix issue 106.#107
Merged
Merged
Conversation
Contributor
|
Hard to tell simply by looking the code. In general it is customary to test fixes before submitting them. |
Contributor
Author
|
It just compiled fine it but I don't have the IFC file you observed the issue to test it with. |
Contributor
|
Should be observable with any file, simply use e.g. |
Contributor
Author
|
Could you please copy-and-paste your IfcConvert output please? Seems to be fine with a test IFC file I'm using. |
Contributor
|
|
Contributor
Author
|
@Stinkfist0 Yes it fixes it. @aothms this fix is ready to merge. Many thanks. |
Contributor
|
Great, thanks. |
Member
|
Thanks guys |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Stinkfist0 Does this fix the problem?