Skip to content

proposed fix issue 106.#107

Merged
aothms merged 1 commit into
IfcOpenShell:masterfrom
iras:issue_106
Jul 19, 2016
Merged

proposed fix issue 106.#107
aothms merged 1 commit into
IfcOpenShell:masterfrom
iras:issue_106

Conversation

@iras

@iras iras commented Jul 19, 2016

Copy link
Copy Markdown
Contributor

@Stinkfist0 Does this fix the problem?

@Stinkfist0

Copy link
Copy Markdown
Contributor

Hard to tell simply by looking the code. In general it is customary to test fixes before submitting them.

@iras

iras commented Jul 19, 2016

Copy link
Copy Markdown
Contributor Author

It just compiled fine it but I don't have the IFC file you observed the issue to test it with.

@Stinkfist0

Stinkfist0 commented Jul 19, 2016

Copy link
Copy Markdown
Contributor

Should be observable with any file, simply use e.g. --verbose --center-model.

@iras

iras commented Jul 19, 2016

Copy link
Copy Markdown
Contributor Author

Could you please copy-and-paste your IfcConvert output please?

Seems to be fine with a test IFC file I'm using.

@Stinkfist0

Copy link
Copy Markdown
Contributor

>IfcConvert.exe ..\..\test\input\acad2010_objects.ifc --center-model --verbose

IfcOpenShell IFC2X3 IfcConvert 0.5.0-dev
Scanning file...
Done scanning file
Creating geometry...
Done creating geometry (52 objects)

Log:
[Notice] Using world coords when writing WaveFront OBJ files
[Notice] {2Kkkz43YFqUW00000007xe} Using model offset (-26.38,-50.51,-1.42502)


Conversion took 2 seconds

@iras

iras commented Jul 19, 2016

Copy link
Copy Markdown
Contributor Author

@Stinkfist0 Yes it fixes it.

@aothms this fix is ready to merge. Many thanks.

@Stinkfist0

Copy link
Copy Markdown
Contributor

Great, thanks.

@aothms aothms merged commit cd2b0c3 into IfcOpenShell:master Jul 19, 2016
@aothms

aothms commented Jul 19, 2016

Copy link
Copy Markdown
Member

Thanks guys

@iras iras deleted the issue_106 branch July 19, 2016 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants