Cmake improvements: LINK_DIRECTORIES and OCCT 7#114
Merged
Conversation
| ) | ||
| IF(NOT "${PCRE_LIBRARY_DIR}" STREQUAL "") | ||
|
|
||
| # Use the found libTKernel as a template for all other OCC libraries |
Contributor
There was a problem hiding this comment.
Typo referring to the wrong library here?
Contributor
|
BTW this broke MSVC debug build (trying to link to library_d_.lib_d_ instead of library_d_.lib), but I'll fix it in my OCCT 7.0.0 pull request. |
Contributor
|
But I don't mind if you find a fix soon ;) I'm currently working getting RelWithDebInfo IfcOpenShell to build against the latest OCCT (need to link to some new libraries at least on MSVC). |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link directories
e9bd18f
Fixes #111. There are issues with
LINK_DIRECTORIESand multiple installations of Open Cascade. This is brittle as linker is invoked with-Lpath_1 ... -Lpath_n -llib_1 ... -llib_nand nothing is known on which is lib is to be located from which path. By using absolute paths in cmake the linker is invoked withpath_1/lib_1 ... path_n/lib_n.From https://cmake.org/cmake/help/v3.0/command/link_directories.html
OCCT 7
1def5db
It appears IfcOpenShell runs and compiles fine with OCCT 7. OCCT 7 comes with a relatively complete cmake script including the options for building static libs on Windows (no static runtime though), contrary to 6.9.1 and therefore is a now a suitable candidate for linking with IfcOpenShell. OCCT 7 requires
-std=c++11, so the version number is determined in CMake.At first sight it seems that http://git.dev.opencascade.org/gitweb/?p=occt.git;a=tree;h=V7_0_0 is not completely identical to https://www.opencascade.com/sites/default/files/private/occt/OCC_7.0.0_release/opencascade-7.0.0.tgz