Skip to content

More elaborate wire ordering check and shell sewing code#147

Merged
aothms merged 3 commits into
IfcOpenShell:masterfrom
aothms:ccw
Dec 9, 2016
Merged

More elaborate wire ordering check and shell sewing code#147
aothms merged 3 commits into
IfcOpenShell:masterfrom
aothms:ccw

Conversation

@aothms

@aothms aothms commented Oct 19, 2016

Copy link
Copy Markdown
Member

No description provided.

@jf---

jf--- commented Oct 19, 2016

Copy link
Copy Markdown
Contributor

@aothms , a current PR at tigl also deals with this aspect... might be interesting?

@aothms

aothms commented Oct 19, 2016

Copy link
Copy Markdown
Member Author

@jf-- interesting, thanks. Can you point me to it directly? I couldn't find it in your link.

if (success) {
// If the wires are reversed the face needs to be reversed as well in order
// to maintain the counter-clock-wise ordering of the bounding wire's vertices.
if (num_bounds == 1 || true) {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: change this condition.

@jf---

jf--- commented Oct 19, 2016

Copy link
Copy Markdown
Contributor

@aothms nothing specific, i glanced over it and it seemed relevant, non-trivial, but easy to follow code, tangential to this topic, possible...

@aothms

aothms commented Nov 6, 2016

Copy link
Copy Markdown
Member Author

@jf---, maybe we should establish some common best practices and code snippets, also re the discussions in tpaviot/pythonocc-core#351 and similar to what has been made available @ http://opencascade.wikidot.com/recipes

I would happily lend http://academy.ifcopenshell.org for this purpose, but perhaps the github OCE wiki page is a more neutral environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants