IfcConvert enhancements#179
Conversation
…ts own class, SerializerSettings.
Sets the decimal precision to be used to format floating-point values, 15 by default. Use a negative value to use the system's default precision (should be 6 typically). Applicable for OBJ and DAE output. For DAE output, value >= 15 means that up to 16 decimals are used, and any other value means that 6 or 7 decimals are used.
…erSettings::DEFAULT_PRECISION in order to fix compilation on GCC & Clang.
|
I could also throw in the --model-offset feature to the same pull request soon or provide a new PR with it, whatever suits you the best. Edit: jumped the gun. ;) |
…::CENTER_MODEL as unneeded.
Stinkfist0
changed the title
|
I could also squeeze in |
Stinkfist0
changed the title
|
OK, that should be it for now. |
| offset[1] = -center.Y(); | ||
| offset[2] = -center.Z(); | ||
| } else { | ||
| if (sscanf(offset_str.c_str(), "%lf;%lf;%lf", &offset[0], &offset[1], &offset[2]) != 3) { |
There was a problem hiding this comment.
Wonder if we need to do something with setlocale() here? I'm somewhat surprised that I need to use a dot as a decimal separator even though my OS is set to believe in the mainland European convention of using commas. It's a minor issue and I'm sure users can figure this out for themselves.
|
Wonderful, just waiting for your opinion on the locale thing and then I will merge it. |
|
Hmm, I'm suspecting we never set the locale explicitly anywhere; the default implicit locale for any C and C++ programs should be (IIRC) the C locale. |
|
Yeah just I had to get too so much trouble to make 100% sure it is the C locale in the parser [1] that I got a bit allergic to this. But I suppose this is mostly for *nix users messing with [1] https://github.com/IfcOpenShell/IfcOpenShell/blob/master/src/ifcparse/IfcParse.cpp#L48 |
2 participants
--precision
--model-offset
--unicode
re: #20 #73 #122