Bring IfcMax up to date#35
Merged
Merged
Conversation
Contributor
Author
Contributor
Author
|
If I may suggest, cmake/CMakeLists.txt could be now maybe moved to the project root which seems to be typical for CMake-based projects. |
Contributor
Author
|
Documented GCC 4.7 as the minimum requirement due to OpenCOLLADA requirements. |
6 tasks
Member
|
Hi, many thanks for this. Sorry for the slow reply. I do have some small points for improvements, but for me they are of low priority as I expect the intersection of 3dsmax users and people compiling their own software rather small. I created a separate issue to track them [1] and will get to it in good time. Major thing is that everything is covered from within cmake, which is a major step forward. Thanks for your efforts. [1] #40 |
aothms
added a commit
that referenced
this pull request
Feb 27, 2016
Create CMake file for building IfcMax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with VS 2015 and 3ds Max 2016 + SDK by importing acad2010_objects.ifc. Closes #13
Having CMakeLists.txt complete for all projects makes the old manually crafted VS solution and project files obsolete so I removed them.