Hi,

Many thanks again for your amazing contribution. Shall I wait for the additions you mentioned or just merge it in?

My main comment would be that I am not a big fan of the binaries in the utils/ folder. But I don't think such considerations have to play a big role now.

I think I will replace them with small python scripts some time after merging. What do you think of this idea? It should be fairly straightforward to emulate wget and 7z (for PKzip) in small python scripts, colored printing would be less straightforward unless a module like colorama is installed.

Kind regards,
Thomas

I would like to get the effortless Debug/Release switching in and after that this should be good for merging. Can you take care of the CMakeLists.txt for IfcMax (which should be trivial probably) as I don't have 3ds Max available? After this I think the old manually maintained solution files should/could be removed for good.

Ah yes, small Python scripts could be used to replace 7zip and wget, but if wanting to keep the build script fully automatized, how would we automatically install Python? PowerShell could be one option too. Or we could just ask the user to install Python manually as a prerequisite. For colored printing I'll see if I can find a non-executable replacement. If not, the whole coloring biz can be naturally omitted. EDIT: I might have found a batch file only replacement for cecho

Sure, I will take care of IfcMax. I think to install Python manually as a prerequisite isn't a big problem, after all the compiler needs to be there as well.

Pending small cleanup (incl. text coloring biz rework) and after that I think this should be good for a merge!

Wonderful :)

Usage instructions will be now printed upon error situations:

OK, all the issues/notes with the exception of OpenCOLLADA + libxml2 are now handled, I'll try rebuilding OpenCOLLADA from the scratch to see if I can repro this issue. Edit: OpenCOLLADA built successfully. Edit2: screenshots in the original post updated.

Would you like to me to create a clean PR so that we could get rid of the unnecessary wget and cecho binaries in the history?

OK, I think I found the reason why I don't have the LibXml2 problems you're having:

-- Could NOT find LibXml2 (missing:  LIBXML2_LIBRARIES LIBXML2_INCLUDE_DIR)
WARNING: Native LibXml2 not found, taking LibXml from ./Externals

You probably have your LibXml2 environment variables set and there are problems with arbitrary LibXml2 versions and OpenCOLLADA's current codebase?

Not necessary to create a new PR / rewrite history. If the repo becomes bloated due to history we can git-filter-branch later. For example, the IFC models will probably also be separated into a different repo some time.

I'll check the build log tomorrow, it's not my regular dev machine, so it's not immediately obvious where it would find a libxml somewhere, but never know for sure.

Yep, you were right

-- Found LibXml2: D:/downloads/gnuwin32/GetGnuWin32/gnuwin32/lib/libxml2.lib (found version "2.4.12") 
-- SUCCESSFUL: LibXml2 found
-- Found PCRE: D:/downloads/gnuwin32/GetGnuWin32/gnuwin32/include  
-- SUCCESSFUL: PCRE found

I don't understand how cmake is able to find this. Neither in FindLibXml2.cmake nor OpenCOLLADA/CMakeLists.txt I see easy ways to force cmake to stick the one that ships with OpenCOLLADA.

Any ideas?

Maybe make the script to set LIBXML2_LIBRARIES and LIBXML2_INCLUDE_DIR to empty before CMake for OpenCOLLADA to enforce that the embedded version of LibXml2 is used? And probably best to do the same for PCRE too.

Yep, you're completely right. This works for me:

call :RunCMake -DCMAKE_INSTALL_PREFIX="%INSTALL_DIR%\OpenCOLLADA" -DUSE_STATIC_MSVC_RUNTIME=1 -DCMAKE_DEBUG_POSTFIX=d -DLIBXML2_LIBRARIES="" -DLIBXML2_INCLUDE_DIR="" -DPCRE_INCLUDE_DIR="" -DPCRE_LIBRARIES=""

OK, I'll add those.

OK, ready to go! I'll provide a new PR for possible further developments.

This is an amazing contribution. IfcOpenShell builds flawlessly. Thanks for all your efforts.

Hmm, the formatting on the README.md's Compiling on Windows section seems a bit off. Edit: newlines before and after the cmd prompt biz section could maybe fix that.

BTW which Windows and VS versions you tested these with?

I tested with VS2015 CE on Windows 7.

Hey, made a small change to your script. I observed that git pull returned a non-zero exit code (at least my version on my system did) when there were no new changes. Made the script no longer halt in that case.

Also made some changes to CMake, but as far as my testing goes, that only affects *nix.

Check out the *nix buildscript btw in case you're interested.

aothms@18f8d7b

Nice! BTW regarding Boost libs, system will be required for thread and date_time for regex. I'm using regex at the old branch, but not thread yet (I started toying around threading IfcConvert but had no time the get anything concrete running). So, those can be omitted now, but I'll be bringing back regex and date_time in the near future.